[ECP-8337] Update merchant name in google pay express checkout component #237
Conversation
…ying of the correct MErchant Name on the redirect screen
Summary of ChangesHello @khushboo-singhvi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Google Pay express checkout component was displaying an incorrect merchant account name. By modifying the configuration to use the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the merchant name for the Google Pay express checkout component to use the gatewayMerchantId. The change aligns with the description and promotes consistency with the main checkout page's Google Pay implementation. I've identified one potential high-severity issue regarding the validation of this new configuration value to prevent the component from breaking if the value is empty, and I have left a comment with details.
| gatewayMerchantId: googlePaymentMethod.configuration.gatewayMerchantId, | ||
| merchantId: googlePaymentMethod.configuration.merchantId, | ||
| merchantName: config.merchantAccount | ||
| merchantName: googlePaymentMethod.configuration.gatewayMerchantId |
There was a problem hiding this comment.
While this change correctly uses gatewayMerchantId for the merchant name as intended, there's a potential issue if this value is empty. The Google Pay API requires a non-empty string for merchantName. If googlePaymentMethod.configuration.gatewayMerchantId is an empty string from the configuration, the Google Pay component may fail to initialize or function correctly. It would be more robust to add validation to ensure this value is not empty before it's used. A good place for this validation would be alongside the existing configuration checks (e.g., around lines 129, 170, or 245).
|
Summary
We currently use the actual MerchantName for the Google pay component. This displays incorrect Merchant Account. With this PR adding
gatewayMerchantIdas the correct MErchant name and also mainting the consistency with the Checkout page GooglePay payment method.