[Bug]: Status PaymentConfirmed - missing option empty / "-- Please Select --"

[cmacaire]

Description

No change Status when we receive "PaymentConfirmed" of Adyen

Steps to reproduce

In the menu we can select a Empty option
Payment confirmed => ['value' => '', 'label' => __('-- Please Select --')]]

Actual behavior

we need to insert a status at this stage, but we can't know the right status depending on the order progress, whether it's awaiting delivery (processing) or already delivered and invoiced (complete).

Expected behavior

In the menu we need select a Empty option to no change the status
Payment confirmed => ['value' => '', 'label' => __('-- Please Select --')]]

Code snippet or screenshots (if applicable)

In the file adyen/module-payment/Model/Config/Source/PaymentConfirmed.php

We need an ‘empty’ status so that we don't update the order status when we receive confirmation of payment from Adyen at the end of the order cycle.
In this way, we can keep the status from the previous stage.

public function toOptionArray(): array
{
    $statuses = $this->stateStatuses
        ? $this->_orderConfig->getStateStatuses($this->stateStatuses)
        : $this->_orderConfig->getStatuses();

  // Before
     **$options = [];**
 // After
    **$options = [['value' => '', 'label' => __('-- Please Select --')]];**
    foreach ($statuses as $code => $label) {
        $options[] = ['value' => $code, 'label' => $label];
    }

    return $options;
}

Adyen Magento Plugin version

9.17.1

Magento version

2.4.7 p5

Operating System

None

Browser (if applicable)

No response

Additional context and logs

No response

[candemiralp]

Hello @cmacaire,

Thank you for raising this issue here. I am trying to understand to whole order and payment journey to create a ticket and investigate internally.

Could you please share a sample order journey step by step including actions (payment, invoice, shipment etc.), capture mode, payment method and any relevant details which can affect the order status? Afterwards, we will create an internal ticket to investigate the case.

Best Regards,
Can

[cmacaire]

In your code, we have these lines:

adyen/module-payment/Helper/Order.php

It is possible to have no status for this notification.
"// If a status is set, add comment, set status and update the state based on the status
// Else add comment"

But here, in the predefined status for Payment_Confimed, we cannot choose Empty status for this step:
adyen/module-payment/Model/Config/Source/PaymentConfirmed.php

If a store has several delivery methods.

Normally we invoice at the end after shipping, but for one delivery method we have to invoice first.

So you can't choose the status for this notification in advance.
You have to stay in the order cycle.
We may be processing or we may be complete, which is why we need to keep the status of the previous stage.

In our case, we overloaded this code to simply add
$options = [[‘value’ => ‘’, ‘label’ => __(‘-- Please Select --’)]];
and it works.

[cmacaire]

in our case, the invoice is the last step, after the shipping
"Complete" is not a status enable in the configuration.