Create internal input with dropdown #794
Open
+148
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
german664
changed the title
german664
force-pushed
the
feature/create-input-with-dropdown
branch
from
5c03e78 to
c47c660
Compare
german664
changed the title
german664
force-pushed
the
feature/create-input-with-dropdown
branch
from
c47c660 to
9ea3bcf
Compare
german664
force-pushed
the
feature/create-input-with-dropdown
branch
from
9ea3bcf to
92558ca
Compare
| } | ||
|
|
||
| .adyen-pe-button--tertiary { | ||
| font-weight: 400; |
Contributor
There was a problem hiding this comment.
Could we use a token for this?
| background: transparent; | ||
| outline: none; | ||
| border: 0; | ||
| outline: none !important; |
Contributor
There was a problem hiding this comment.
Is there a way we could avoid using !important here? It will make it more difficult for final users to override this.
| {hasIcons ? ( | ||
| {hasDropdownOrIcons ? ( | ||
| <div className="adyen-pe-input__container"> | ||
| {shouldDisplayDropdownAtStart && dropdown && ( |
Contributor
There was a problem hiding this comment.
is the && dropdown verification redundant? we're already checking that dropdown is truthy in shouldShowDropdown
| {iconAfter} | ||
| </span> | ||
| )} | ||
| {shouldDisplayDropdownAtEnd && dropdown && ( |
Comment on lines
+190
to
+191
| onClickCapture={e => e.stopPropagation()} | ||
| onMouseDownCapture={e => e.stopPropagation()} |
Contributor
There was a problem hiding this comment.
nit: Seems a little odd to stop the propagation in the parent div, we could consider an alternative approach?
| onMouseDownCapture={e => e.stopPropagation()} | ||
| > | ||
| <Select | ||
| items={dropdown.items} |
Contributor
There was a problem hiding this comment.
To have the same styles with dropdown position start below can be added
buttonVariant={ButtonVariant.TERTIARY}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBL Creation Flow: Internal form input fields
Fixed issue: IEX-1052