Restrict number input characters in Firefox

[samuelsarabia-adyen]

Summary

Restricts allowed characters in type="number" input

[gemini-code-assist]

Summary of Changes

Hello @samuelsarabia-adyen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces client-side validation for type="number" input fields to enhance data integrity and user experience, particularly in Firefox. It ensures that only valid numeric characters, including digits, a single decimal point (either comma or period), and a minus sign, can be entered, preventing invalid input from reaching the application logic.

Highlights

• Input Character Restriction: Implemented a handleKeyPress function to restrict characters allowed in type="number" input fields, specifically targeting Firefox compatibility.
• Decimal Point Handling: The new logic prevents users from entering multiple decimal points (both '.' and ',') in number input fields, ensuring valid numerical input.
• Prop Cleanup: Removed unused autoCorrect and spellCheck props from the InputBaseProps interface and the InputBase component, streamlining the component's API.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to restrict character input for number fields. The implementation in handleKeyPress has some critical issues, such as blocking backspace and other essential keys, and incorrect handling of the minus sign. I've provided a suggestion to fix this. Additionally, the PR removes autoCorrect and spellCheck properties, which seems unrelated and could negatively affect other input types using this base component. I've raised a question about this change to clarify if it was intentional.

[gemini-code-assist]

The properties autoCorrect and spellCheck have been removed from InputBaseProps. This InputBase component is used for various input types, including text (it's the default type), where these properties are quite useful for user experience.

Since this change seems unrelated to restricting characters in number inputs (the main goal of this PR), could you clarify if this removal was intentional? If it was, it might be better to move this change to a separate PR with its own justification. If it was unintentional, these properties should be added back to avoid breaking functionality for text-based inputs.

[samuelsarabia-adyen]

Props were unused in the <InputBase/> component.