Skip to content

Conversation

@samuelsarabia-adyen
Copy link
Contributor

Summary

  • Adds the PBL Store Selector internal component
  • Adds useStores hook for data fetching
  • Normalizes SelectChangeEvent strict typing

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @samuelsarabia-adyen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on implementing a new internal PBL Store Selector component, which includes a dedicated useStores hook for efficient data fetching and state management of available stores. Concurrently, it refines the Select component's onChange event handling by introducing and enforcing a strict SelectChangeEvent type across multiple existing components, thereby enhancing type safety and consistency throughout the codebase. The Select component also gains a new feature allowing custom rendering of its button content.

Highlights

  • PBL Store Selector Component: Introduced a new internal StoreSelector component, designed to display and manage a list of stores.
  • useStores Hook: Added a new hook, useStores, responsible for fetching store data from an API endpoint and managing the selected store state.
  • Strict SelectChangeEvent Typing: Normalized and strictly typed the onChange event parameter for the Select component across various files, improving type safety and developer experience.
  • Custom Select Button Rendering: Enhanced the Select component to support custom rendering of its button content via a new renderButtonContent prop.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new StoreSelector internal component and a corresponding useStores hook for data fetching. A significant improvement is the normalization of SelectChangeEvent for stricter typing across various components, which enhances type safety. The implementation is solid, but I've identified a few areas for improvement, including a critical case of code duplication, a redundant test, and an opportunity to simplify component logic for better maintainability. My detailed feedback is in the comments below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants