-
Notifications
You must be signed in to change notification settings - Fork 1
Implement PBL Store Selector internal component #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: group/pay-by-link-component
Are you sure you want to change the base?
Implement PBL Store Selector internal component #824
Conversation
Summary of ChangesHello @samuelsarabia-adyen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on implementing a new internal Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new StoreSelector internal component and a corresponding useStores hook for data fetching. A significant improvement is the normalization of SelectChangeEvent for stricter typing across various components, which enhances type safety. The implementation is solid, but I've identified a few areas for improvement, including a critical case of code duplication, a redundant test, and an opportunity to simplify component logic for better maintainability. My detailed feedback is in the comments below.
b5d5023 to
6787004
Compare
6787004 to
dcd8253
Compare
Summary
SelectChangeEventstrict typing