-
Notifications
You must be signed in to change notification settings - Fork 1
Mock transactions download endpoint #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: group/transactions-v2
Are you sure you want to change the base?
Mock transactions download endpoint #830
Conversation
Summary of ChangesHello @glad-adyen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational elements for a new feature allowing the download of transaction data. It defines the endpoint's structure, integrates it into the mock server for development purposes, and updates the API's type definitions to ensure proper handling of the CSV output and associated filtering parameters. This work directly addresses the requirement to create mock data for the transaction export functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request sets up the necessary definitions and mock server configuration for a new transactions download endpoint. The changes are well-structured and consistent with the existing codebase. I've identified a couple of areas for improvement in the API type definition file: one regarding the accuracy of a comment, and a more significant one concerning the process of updating auto-generated files.
10b6ae2 to
59be218
Compare
Summary
This PR introduces changes required for mocking the transactions download endpoint.
Fixed issue: IEX-1222: Create mock data for transactions export endpoint