Cherry-pick #11113: Fix WCPay Subscriptions toggle not saving when unchecked (#11114)

Co-authored-by: Miguel Gasca <[email protected]>

Author: dmallory42

changelog/fix-woopmnt-5394-fix-wcpay-subscriptions-toggle-not-saving-when-unchecked

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Fix - WCPay Subscriptions setting not persisting when unchecked

includes/admin/class-wc-rest-payments-settings-controller.php

@@ -134,7 +134,7 @@ public function register_routes() {
 						'type'              => 'boolean',
 						'validate_callback' => 'rest_validate_request_arg',
 					],
-					'is_wcpay_subscription_enabled'        => [
+					'is_wcpay_subscriptions_enabled'       => [
 						'description'       => sprintf(
 							/* translators: %s: WooPayments */
 							__( '%s Subscriptions feature flag setting.', 'woocommerce-payments' ),
@@ -803,11 +803,11 @@ private function update_is_multi_currency_enabled( WP_REST_Request $request ) {
 	 * @param WP_REST_Request $request Request object.
 	 */
 	private function update_is_wcpay_subscriptions_enabled( WP_REST_Request $request ) {
-		if ( ! $request->has_param( 'is_wcpay_subscription_enabled' ) ) {
+		if ( ! $request->has_param( 'is_wcpay_subscriptions_enabled' ) ) {
 			return;
 		}
 
-		$is_wcpay_subscriptions_enabled = $request->get_param( 'is_wcpay_subscription_enabled' );
+		$is_wcpay_subscriptions_enabled = $request->get_param( 'is_wcpay_subscriptions_enabled' );
 
 		// Prevent enabling bundled subscriptions - feature has been removed in 10.2.0.
 		// Only allow disabling the feature if it was previously enabled.

tests/unit/admin/test-class-wc-rest-payments-settings-controller.php

@@ -654,7 +654,7 @@ public function test_update_settings_disables_wcpay_subscriptions() {
 			->method( 'store_setup_sync' );
 
 		$request = new WP_REST_Request();
-		$request->set_param( 'is_wcpay_subscription_enabled', false );
+		$request->set_param( 'is_wcpay_subscriptions_enabled', false );
 
 		$this->controller->update_settings( $request );
 
@@ -670,7 +670,7 @@ public function test_update_settings_does_not_enable_wcpay_subscriptions() {
 			->method( 'store_setup_sync' );
 
 		$request = new WP_REST_Request();
-		$request->set_param( 'is_wcpay_subscription_enabled', true );
+		$request->set_param( 'is_wcpay_subscriptions_enabled', true );
 
 		$this->controller->update_settings( $request );