Enforce character alias to be a list

Author: Buried-In-Code

build.gradle.kts

@@ -14,7 +14,7 @@ println("Java v${System.getProperty("java.version")}")
 println("Arch: ${System.getProperty("os.arch")}")
 
 group = "github.buriedincode"
-version = "0.2.1"
+version = "0.2.2"
 
 repositories {
     mavenCentral()

cache.sqlite

@@ -74,7 +74,7 @@ class Metron(
                     .newBuilder()
                     .uri(uri)
                     .setHeader("Accept", "application/json")
-                    .setHeader("User-Agent", "Kalibak/0.2.1 (${System.getProperty("os.name")}/${System.getProperty("os.version")}; Kotlin/${KotlinVersion.CURRENT})")
+                    .setHeader("User-Agent", "Kalibak/0.2.2 (${System.getProperty("os.name")}/${System.getProperty("os.version")}; Kotlin/${KotlinVersion.CURRENT})")
                     .setHeader("Authorization", this.authorization)
                     .GET()
                     .build()

src/main/kotlin/github/buriedincode/kalibak/Metron.kt

@@ -1,5 +1,6 @@
 package github.buriedincode.kalibak.schemas
 
+import github.buriedincode.kalibak.serializers.EmptyListSerializer
 import github.buriedincode.kalibak.serializers.NullableStringSerializer
 import kotlinx.datetime.Instant
 import kotlinx.serialization.ExperimentalSerializationApi
@@ -9,6 +10,7 @@ import kotlinx.serialization.json.JsonNames
 @OptIn(ExperimentalSerializationApi::class)
 @Serializable
 data class Character(
+    @Serializable(with = EmptyListSerializer::class)
     val alias: List<String> = emptyList(),
     @JsonNames("cv_id")
     val comicvineId: Long? = null,

src/main/kotlin/github/buriedincode/kalibak/schemas/Character.kt

@@ -0,0 +1,23 @@
+package github.buriedincode.kalibak.serializers
+
+import kotlinx.serialization.ExperimentalSerializationApi
+import kotlinx.serialization.KSerializer
+import kotlinx.serialization.builtins.ListSerializer
+import kotlinx.serialization.descriptors.SerialDescriptor
+import kotlinx.serialization.descriptors.listSerialDescriptor
+import kotlinx.serialization.encoding.Decoder
+import kotlinx.serialization.encoding.Encoder
+
+class EmptyListSerializer<T>(private val elementSerializer: KSerializer<T>) : KSerializer<List<T>> {
+    @OptIn(ExperimentalSerializationApi::class)
+    override val descriptor: SerialDescriptor = listSerialDescriptor(elementSerializer.descriptor)
+
+    @OptIn(ExperimentalSerializationApi::class)
+    override fun deserialize(decoder: Decoder): List<T> {
+        return decoder.decodeNullableSerializableValue(ListSerializer(elementSerializer)) ?: emptyList()
+    }
+
+    override fun serialize(encoder: Encoder, value: List<T>) {
+        encoder.encodeSerializableValue(ListSerializer(elementSerializer), value)
+    }
+}

src/main/kotlin/github/buriedincode/kalibak/serializers/EmptyListSerializer.kt

@@ -69,5 +69,23 @@ class CharacterTest {
                 session.getCharacter(id = -1)
             }
         }
+
+        @Test
+        fun `Test GetCharacter with a null alias`() {
+            val result = session.getCharacter(id = 25657)
+            assertNotNull(result)
+            assertAll(
+                { assertTrue(result.alias.isEmpty()) },
+            )
+        }
+
+        @Test
+        fun `Test GetCharacter with an alias`() {
+            val result = session.getCharacter(id = 648)
+            assertNotNull(result)
+            assertAll(
+                { assertEquals("Spy-D", result.alias[0]) },
+            )
+        }
     }
 }