-
Notifications
You must be signed in to change notification settings - Fork 2
Stop Pre-Commit From Running On Model Output And Metadata Folders #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop Pre-Commit From Running On Model Output And Metadata Folders #124
Conversation
sbidari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @O957
|
dylanhmorris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
I will defer to @sbidari to answer this, given that she is the one who requested this change. |
I created an issue for this after seeing pre-commit failure on model submission PR. Agree we can exclude by file extensions instead of directories. |
|
Got it, thanks. Edited #122. |
…tput-and-metadata-folders
dylanhmorris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to make yaml extension general
Co-authored-by: Dylan H. Morris <[email protected]>
This PR:
pre-commit.cifrom running on the foldersmodel-outputormodel-metadata..yamlin Metadata Folders #122