Skip to content

Conversation

@O957
Copy link
Collaborator

@O957 O957 commented Sep 24, 2025

This PR:

  • Prevents pre-commit.ci from running on the folders model-output or model-metadata.

sbidari
sbidari previously approved these changes Sep 24, 2025
Copy link
Collaborator

@sbidari sbidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @O957

@dylanhmorris
Copy link
Collaborator

  • @O957 can you explain what problem(s) this solves?
  • If, as I suspect, it has to do with not wanting to impose pre-commit on contributed .csv, .parquet, and .yaml files, it would be better just to exclude those specific extensions. We still ideally want to run pre-commit on (e.g.) the README.md files in those directories.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@O957
Copy link
Collaborator Author

O957 commented Sep 24, 2025

  • @O957 can you explain what problem(s) this solves?

    • If, as I suspect, it has to do with not wanting to impose pre-commit on contributed .csv, .parquet, and .yaml files, it would be better just to exclude those specific extensions. We still ideally want to run pre-commit on (e.g.) the README.md files in those directories.

I will defer to @sbidari to answer this, given that she is the one who requested this change.

@sbidari
Copy link
Collaborator

sbidari commented Sep 24, 2025

  • @O957 can you explain what problem(s) this solves?
  • If, as I suspect, it has to do with not wanting to impose pre-commit on contributed .csv, .parquet, and .yaml files, it would be better just to exclude those specific extensions. We still ideally want to run pre-commit on (e.g.) the README.md files in those directories.

I created an issue for this after seeing pre-commit failure on model submission PR. Agree we can exclude by file extensions instead of directories.

@dylanhmorris
Copy link
Collaborator

Got it, thanks. Edited #122.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make yaml extension general

Co-authored-by: Dylan H. Morris <[email protected]>
@O957 O957 merged commit aeb9559 into main Sep 24, 2025
5 checks passed
@O957 O957 deleted the 122-stop-pre-commit-from-running-on-model-output-and-metadata-folders branch September 24, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop Pre-Commit From Running On .parquet and .csv in Model Output folder and .yaml in Metadata Folders

4 participants