Skip to content

Conversation

@qianxuege
Copy link

@qianxuege qianxuege commented Nov 11, 2025

Note: This is adapted from Alicia's PR #2

Name of PR: Add translator tests to CI workflow

Description:

  • Added test/unit/test_translator.py to github CI workflow for pushes and pull requests.

Changes

What changes did you make to resolve the issue?

  • Updated .github/workflows/test.yml to ensure all tests in the test/ directory are executed during CI.
  • Verified CI triggers on both push and pull_request events for the main branch.

Does your change introduce new dependencies to this project? If so, list here.

  • No — this PR does not add any new dependencies.

Validation

How did you trigger the change to show that it is working?

  • Pushed a test branch with the new workflow updates.
  • Observed that GitHub Actions executed the workflow automatically.
  • Verified that pytest discovered and ran test/unit/test_translator.py as part of the suite.
  • Confirmed all tests passed successfully.
image

@jarchenn jarchenn self-requested a review November 11, 2025 22:25
Copy link

@jarchenn jarchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions to the workflow add to the CI setup that automatically runs. Overall, these updates make the project more robust and aligned with any modern CI/CD best practices. All checks pass locally when I tested as well.

@jarchenn jarchenn merged commit 9c02ff6 into f25 Nov 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants