Skip to content

Commit e7ccd50

Browse files
authored
Use torch CUDA 12.6 as default (#237)
1 parent 1f7e490 commit e7ccd50

File tree

6 files changed

+13
-6
lines changed

6 files changed

+13
-6
lines changed

.github/workflows/run-on-gpu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
env:
6262
PYTHONPATH: ${{ github.workspace }}
6363
TEST_E2E: true
64-
TEST_E2E_COMFY_INSTALL_FLAGS: --nvidia --cuda-version 12.4
64+
TEST_E2E_COMFY_INSTALL_FLAGS: --nvidia --cuda-version 12.6
6565
TEST_E2E_COMFY_LAUNCH_FLAGS_EXTRA: ""
6666
run: |
6767
pytest tests/e2e

.github/workflows/test-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
python -m pip install --upgrade pip
3030
pip install pytest
3131
pip install -e .
32-
comfy --skip-prompt --workspace ./ComfyUI install --fast-deps --nvidia --cuda-version 12.4 --skip-manager
32+
comfy --skip-prompt --workspace ./ComfyUI install --fast-deps --nvidia --cuda-version 12.6 --skip-manager
3333
comfy --workspace ./ComfyUI standalone --platform windows --proc x86_64
3434
ls
3535
comfy standalone --rehydrate --platform windows --proc x86_64

comfy_cli/cmdline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ def install(
198198
callback=g_gpu_exclusivity.validate,
199199
),
200200
] = None,
201-
cuda_version: Annotated[CUDAVersion, typer.Option(show_default=True)] = CUDAVersion.v12_4,
201+
cuda_version: Annotated[CUDAVersion, typer.Option(show_default=True)] = CUDAVersion.v12_6,
202202
amd: Annotated[
203203
Optional[bool],
204204
typer.Option(

comfy_cli/command/install.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,13 @@ def pip_install_comfyui_dependencies(
6868
"torchvision",
6969
"torchaudio",
7070
]
71-
if plat == constants.OS.WINDOWS and cuda_version == constants.CUDAVersion.v12_4:
71+
72+
if plat == constants.OS.WINDOWS and cuda_version == constants.CUDAVersion.v12_6:
73+
base_command += [
74+
"--extra-index-url",
75+
"https://download.pytorch.org/whl/cu126",
76+
]
77+
elif plat == constants.OS.WINDOWS and cuda_version == constants.CUDAVersion.v12_4:
7278
base_command += [
7379
"--extra-index-url",
7480
"https://download.pytorch.org/whl/cu124",
@@ -164,7 +170,7 @@ def execute(
164170
commit: Optional[str] = None,
165171
manager_commit: Optional[str] = None,
166172
gpu: constants.GPU_OPTION = None,
167-
cuda_version: constants.CUDAVersion = constants.CUDAVersion.v12_4,
173+
cuda_version: constants.CUDAVersion = constants.CUDAVersion.v12_6,
168174
plat: constants.OS = None,
169175
skip_torch_or_directml: bool = False,
170176
skip_requirement: bool = False,

comfy_cli/constants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class PROC(str, Enum):
6060

6161

6262
class CUDAVersion(str, Enum):
63+
v12_6 = "12.6"
6364
v12_4 = "12.4"
6465
v12_1 = "12.1"
6566
v11_8 = "11.8"

comfy_cli/uv.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def parse_req_file(rf: PathLike, skips: Optional[list[str]] = None):
6565

6666
class DependencyCompiler:
6767
rocmPytorchUrl = "https://download.pytorch.org/whl/rocm6.1"
68-
nvidiaPytorchUrl = "https://download.pytorch.org/whl/cu121"
68+
nvidiaPytorchUrl = "https://download.pytorch.org/whl/cu126"
6969

7070
overrideGpu = dedent(
7171
"""

0 commit comments

Comments
 (0)