Bump electron from 38.4.0 to 39.0.0

[dependabot]

Bumps electron from 38.4.0 to 39.0.0.

Release notes

Sourced from electron's releases.

electron v39.0.0

Release Notes for v39.0.0

Stack Upgrades

• Chromium 142.0.7444.52
  • New in 142
  • New in 141
• Node 22.20.0
  • Node 22.20.0 blog post
• V8 14.2

Breaking Changes

• Added colorSpace to offscreen shared texture info of webContents.on('paint') event.
  • Breaking Changed the signature of OffscreenSharedTexture to provide a unified handle that holds the native handle. #47315
• Fixed a spec compliance issue with window.open where it should always create a resizable popup window but did not. #47540

For breaking changes inherited via Chromium, see blog post

Features

Additions

• Added RGBAF16 output format with scRGB HDR color space support to Offscreen Rendering. #48504
• Added fileBacked and purgeable fields to process.getSystemMemoryInfo() for macOS. #47628 (Also in 37, 38)
• Added support for guid Tray constructor option on macOS to allow tray icons to maintain position across launches. #47838 (Also in 36, 37, 38)
• Added webFrameMain.fromFrameToken(processId, frameToken) to get a WebFrameMain instance from its frame token. #47850 (Also in 38)
• Added methods to enable more granular accessibility support management. #48625
• Added support for app.getRecentDocuments() on Windows and macOS. #45839 (Also in 36, 37, 38)
• Added support for USBDevice.configurations. #47459
• Added the ability to retrieve the system accent color on Linux using systemPreferences.getAccentColor. #48628
• Adds the ability to change window accent color on Windows after initial window initialization via {get|set}AccentColor. #47741 (Also in 36, 37, 38)
• Allowed for persisting File System API grant status within a given session. #48326 (Also in 37, 38)
• Internally switched to using DIR_ASSETS instead of DIR_MODULE/DIR_EXE to locate assets and resources, and added "assets" as a key that can be queried via app.getPath. #47439 (Also in 37, 38)
• Support dynamic ESM imports in non-context isolated preloads. #48488 (Also in 37, 38)

Fixes

• Fixed an issue where systemPreferences.getAccentColor inverted the color. #48624
• Fixed an issue where calling webContents.openDevTools({ mode: 'detach' }) would cause a crash on Wayland. #48623
• Fixed crash when accessing webContents.session. #48344
• Fixed crash when inspector agent attempts to evaluate on provisional frames. #48515
• Fixed crash when passing feature param from commandline --enable-features=Feature:ParamA/Value. #48442

Also in earlier versions...

• AccentColor set distinguishes the frame. #48450 (Also in 37, 38)
• Fix: runtime JS error that crashes GetPackageJSON. #48425 (Also in 37, 38)
• Fixed Wayland configuration through the XDG_SESSION_TYPE environment variable. #48310 (Also in 38)
• Fixed Windows dialog.showMessageBox default button handling. #48521 (Also in 36, 37, 38)
• Fixed a bug where app extensions filters didn't allow for selecting app bundles in macOS file dialogs. #47825 (Also in 36, 37, 38)
• Fixed a bug where the Referer header was not being set correctly when using webContents.downloadURL(). #47625 (Also in 36, 37, 38)
• Fixed a child process crash on macOS when the running application is replaced with one that has a newer implementation triggering the sandbox. #47765 (Also in 37, 38)
• Fixed a crash possible when calling webContents.loadURL() from a failed webContents.loadURL() call's catch handler. #48004 (Also in 36, 37, 38)

... (truncated)

Commits

• 0abda74 docs: modify the thickFrame doc (#48677)
• 4e8a552 fix: logical bug in install.js env var handling (#48673)
• d83383b docs: fix Ubuntu version used to build Electron (#48643)
• 496db94 chore: bump chromium to 142.0.7444.52 (39-x-y) (#48641)
• 00627c6 fix: crash on empty dialog extensions array on Windows (#48658)
• 7319e5c docs: security.md mark 'Enable process sandboxing' as active by defau… (#48647)
• 1056280 feat: enable more granular a11y feature management (#48625)
• 4fda94b feat: Add getAccentColor on Linux (#48628)
• e3715b0 fix: systemPreferences.getAccentColor inverted color (#48624)
• 90674e0 fix: icon in Windows toast notification (#48629)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[PikachuEXE]

https://www.electronjs.org/blog/electron-39-0#breaking-changes
Seems not affecting FT

[ChunkyProgrammer]

getAccentColor is available on linux as well now. IIRC, we talked about being able to use this in the past for theming?

[efb4f5ff-1298-471a-8973-3d47447115dc]

getAccentColor is available on linux as well now. IIRC, we talked about being able to use this in the past for theming?

That would be cool to implement

[absidue]

There is a bug report open on the Electron repo about the system theme detection being broken on with Electron 39: electron/electron#48736

[absidue]

getAccentColor is available on linux as well now. IIRC, we talked about being able to use this in the past for theming?

Yes, the main blocker was never that it wasn't easily accessible (I had hacked together code that manually called the dbus API and checked a few other sources to get it) but that I couldn't come up with a good way to infer/calculate all the other colour properties (my old branch is here: https://github.com/absidue/FreeTube/commits/system-accent-color/)

Jason did suggest at the time that instead of trying to calculate the other properties, we could try to match the system accent colour to one of FreeTube's existing ones with a colour similarity algorithm. Unfortunately that only worked well if FreeTube actually had a similar one, I remember grey being particularly difficult as FreeTube didn't have anything even remotely close to that at the time.

Cant confirm the theming issue due to having wayland issues

Could someone else try to verify this

[efb4f5ff-1298-471a-8973-3d47447115dc]

There is a bug report open on the Electron repo about the system theme detection being broken on with Electron 39: electron/electron#48736

Couldnt reproduce this bug in Manjaro VM. Switching from light to dark and vice versa also switches theme in FT. Do we want to approve and merge?

[absidue]

We could merge it but keep in mind that if any users report that issue that it's an upstream one.

[PikachuEXE]

Or we can wait for next version to see if bug fixed (and include other bug fixes

[efb4f5ff-1298-471a-8973-3d47447115dc]

Im fine with waiting

[absidue]

39.1.0 is out, the changelog doesn't specifically mention the system theme, but does mention another wayland fix and includes a Chromium update.

[PikachuEXE]

Nothing theme related (I read Chromium changelog too
https://github.com/electron/electron/releases/tag/v39.1.0

[dependabot]

Superseded by #8259.