Skip to content

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 9, 2025

Pull Request Type

  • Youtube-ification

Description

I noticed this behavior when I had the Hide profile pictures in comments setting enabled. The profiles within the comment section always used a capital letter, even though I observed some profiles without pictures that used lowercase letters when the setting was turned off. After removing the .toUpperCase() from this setting, I realized we could apply the same approach to our own profiles. This is especially useful when two profiles use the same letter. Previously, the only way to distinguish them was by color, but now the appearance of the letter itself whether capitalized or not also serves as a differentiator.

Screenshots

YT default profile icon when user didn't set profile picture:
Non capitalized icon
FreeTube_6NDdsaupBQ
Capitalized icon
FreeTube_zpbtTRIkx7

Before:
FreeTube_JlhxymLddM
Screenshot (33)

After:
VirtualBoxVM_wu1buMXlms

VirtualBoxVM_zdrF2OBfEL

Testing

Case A:

  1. Go to https://www.youtube.com/post/Ugkx5VXPsw7Q9g9Lw7s4QZi3FqyRSOiwmanV
  2. Check that profile pictures contain capital or non capital letters
  3. Enable Distraction free -> Watch page -> Hide profile pictures in comments
  4. Go to https://www.youtube.com/post/Ugkx5VXPsw7Q9g9Lw7s4QZi3FqyRSOiwmanV again
  5. Check that profile pictures contain capital or non capital letters

Case B:

  1. Create two profiles, one that starts with a capital letter and the other with a lowercase
  2. Check if both uppercase and lowercase letter profiles are visible on all places you can interact with the profile

Desktop

  • OS: Windows 11
  • OS Version: 24H2

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 9, 2025 22:40
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 9, 2025
@PikachuEXE
Copy link
Collaborator

Note that with Hide profile pictures in comments off, YT got author thumbs with sometimes random chars not event matching username, they are still images not text
image

@PikachuEXE
Copy link
Collaborator

Oops not changed here
image

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Good catch i somehow had that still sitting in my stash

@FreeTubeBot FreeTubeBot merged commit d50e3d4 into FreeTubeApp:development Nov 11, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 11, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the change-profile-icon branch November 11, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants