Change profile icon to include lowercase letters #8253
Merged
+5
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Pull Request Type
Description
I noticed this behavior when I had the
Hide profile pictures in commentssetting enabled. The profiles within the comment section always used a capital letter, even though I observed some profiles without pictures that used lowercase letters when the setting was turned off. After removing the.toUpperCase()from this setting, I realized we could apply the same approach to our own profiles. This is especially useful when two profiles use the same letter. Previously, the only way to distinguish them was by color, but now the appearance of the letter itself whether capitalized or not also serves as a differentiator.Screenshots
YT default profile icon when user didn't set profile picture:


Non capitalized icon
Capitalized icon
Before:


After:

Testing
Case A:
Hide profile pictures in commentsCase B:
Desktop