-
Notifications
You must be signed in to change notification settings - Fork 1.4k
update u-net notebooks to Keras 3 #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: keras3-dev
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello @takumiohym, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the U-Net segmentation notebook by migrating its codebase to Keras 3, ensuring compatibility with the latest deep learning framework. A key improvement involves the removal of a flawed image flipping data augmentation strategy that could lead to incorrect feature-label associations, thereby enhancing the reliability of the training process. Additionally, various environment and dependency versions have been updated to align with current best practices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the U-Net segmentation notebook to use Keras 3 APIs, which is a great step towards modernization. The changes mostly involve replacing tf.keras with keras, which has been done correctly in most places. The PR also removes the data augmentation step from the training script, as explained in the description.
My main concern is a critical issue I've found in the data preprocessing logic. The switch from tf.image.convert_image_dtype to keras.ops.cast has removed the pixel value normalization to the [0, 1] range. This will likely cause the model to behave incorrectly during training and inference. I've added two comments with suggestions to fix this, one for the notebook cell and one for the train.py script.
Update summary: