-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Backports for 1.13.0-alpha1 #60048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KristofferC
wants to merge
26
commits into
release-1.13
Choose a base branch
from
backports-release-1.13
base: release-1.13
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backports for 1.13.0-alpha1 #60048
+726
−616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming happened in f9b7d27 / PR #59158 by @JeffBezanson (cherry picked from commit b63991c)
fix a bug in which parsing the digits after the decimal point of a (date-)time like "00:00:00.12" were interpreted as "12 milliseconds" instead of "0.12 seconds". Now, the fractional part is correctly parsed as a fraction of a second, then correctly converted to milliseconds. As before, only the first three digits after the decimal point are considered. Closes #59997 --- With a local build of this PR, the example from the above issue now evaluates to: ```julia julia> t2 = TOML.parse("""time = 00:00:00.2""") Dict{String, Any} with 1 entry: "time" => 00:00:00.2 julia> millisecond(t2["time"]) 200 ``` (cherry picked from commit 906d64e)
Thanks to PermutationGroups.jl for dog-fooding our typos! This now matches the runtime implementation in datatype.c (setonce_bits) and ensures that we properly compute the success bit. The test that was intended to check for this is now written to inline that struct and thus actually test for this (undef fields are not eligible for inlining). Fix #59883 (cherry picked from commit c5553c9)
(cherry picked from commit a933cf4)
Also fix race conditions caused by targets producing files being incorrectly marked as phony. Follow up to #59476 (guess there is a price to pay for using Claude) @lgoettgens that might help with the issues you are seeing in JuliaPackaging/Yggdrasil#12406 (cherry picked from commit ff602d4)
Co-authored-by: Cody Tapscott <[email protected]> (cherry picked from commit d5fb6bb)
(cherry picked from commit d484e19)
Make cache invalidation reason messages clearer and more user-friendly by removing abbreviations and using more positive, informative language. Changes include: - Expanded all abbreviations (e.g., "dep" → "dependency", "fsize" → "file size") - Replaced negative-sounding terms like "wrong" with neutral "different" - Made technical terms clearer (e.g., "ocachefile" → "native code cache file") - Changed "cache misses" to "caches not reused" for more positive framing - Reordered format from "reason (count)" to "count for reason" for better readability Fixes #59255 🤖 Generated with Claude Code (cherry picked from commit bfa0e4d)
(cherry picked from commit fda084f)
(cherry picked from commit 589a8c6)
6 tasks
(cherry picked from commit 6f2f7f5)
When errors occur, `waitall` may skip allocating Channel producers, leading to deadlock in the subsequent loop in the event that the user asked it to failfast (ironically). This is seen often in the failing of the threads_exec test ever since the test was added for this call. Simplify this to just use separate loops for the wait and the return computation. (cherry picked from commit e2f3178)
(cherry picked from commit 32ac2ec)
In Markdown, links are written as `[desc](URL)`, and no space is allowed between `]` and `(`. However, Julia's Markdown parser explicitly accepted it (not clear why). This may break links in a few package manuals, but the fix will be easy in each case (just remove the extra spaces). But being more consistent with most (all??) other Markdown implementations seems more important to me; it is very surprising when one copies basic Markdown that works fine elsewhere into a Julia package manual and it suddenly is treated completely differently. Resolves JuliaDocs/Documenter.jl#2681 (cherry picked from commit fe30573)
this more closely mimics how other editors do it and should hopefully remove a few annoying cases see tests for concrete changes (also make sure that other modes also remove paired delimiters on backspace) Tests and some code written by Claude Code 🤖 Co-authored-by: KristofferC <[email protected]> (cherry picked from commit 0c34bde)
Co-authored-by: KristofferC <[email protected]> (cherry picked from commit 6058082)
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of #56601, #56627. (cherry picked from commit b60d1db)
We cannot store or load results for this world, so recompiling the package a second time for that world is rather pointless. (cherry picked from commit 36ea5ce)
Wasn't sure if we could get away with deleting the `uv_thread_detach`, but apparently we can. On Windows, it's definitely unsafe to keep using the thread handle after closing it. POSIX is a little less clear about what you're allowed to do with a `pthread_t` after detaching it, but the GC threads never exit normally anyway. Fixes #60042. (cherry picked from commit d8b5662)
(cherry picked from commit 8795edd)
(cherry picked from commit 9e75960)
2d9c98b to
79c3bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
pointerarith_tfuncfor Const ptr #60011collect(...)in TOML #59932Non-merged PRs with backport label: