-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Sorry to jump in (hello from the NHS port 👋)
We spotted another issue where a namespace is necessary:
govuk-frontend-jinja/govuk_frontend_jinja/templates/components/character-count/macro.html
Lines 92 to 94 in 4584974
| {%- for name, value in params.formGroup.attributes if params.formGroup %} | |
| {% set attributesHtml = attributesHtml ~ " " ~ name | escape ~ '="' ~ value | escape ~ '"' %} | |
| {% endfor -%} |
Using the same approach as the govukAttributes() macro that should be:
{%- for name, value in (params.formGroup.attributes.items() if params.formGroup.attributes else {}.items()) %}
{% set ns.attributesHtml = '{} {}="{}"'.format(ns.attributesHtml, name | escape, value | escape) %}
{% endfor -%}For our NHS fix (mostly the same) you can see NHSDigital/nhsuk-frontend-jinja@903bcaf
Originally posted by @colinrotherham in #96 (comment)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working