fms2_io: Refactor MPI-IO support #1789
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPI-IO support in fms2_io has been refactored. `open_collective_netcdf_file` has been removed and its functionality has been merged into `netcdf_file_open`. Parallel reads and writes are now enabled using the same interface and code pathways.
Use explicit names for the optional arguments of `netcdf_file_open`, when it's called within `open_domain_file`.
In the netcdf_read_data_* subroutines, move the calls to nf90_var_par_access so that they run later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MPI-IO support in fms2_io has been refactored.
open_collective_netcdf_filehas been removed and merged intonetcdf_file_open, to reduce the amount of duplicated code. The API for using collective reads has been changed to be consistent with parallel writes. Collective read unit tests have been updated to use the new API.Fixes #1767 and #1753
How Has This Been Tested?
Builds on the AMD box, but the collective reads unit tests don't pass. I'm still investigating what the problem is.
Checklist:
make distcheckpasses