Clean JLinK PPK 1 warning #553
Conversation
kylebonnici
added
doc required
KievDevel
left a comment
KievDevel
left a comment
There was a problem hiding this comment.
please add changelog entry
| deviceFilter={device => | ||
| isDeviceInDFUBootloader(device) || | ||
| device.usb?.device.descriptor.idProduct === 0xc00a | ||
| } |
There was a problem hiding this comment.
not sure if we should change behavior here. kinda breaking change
There was a problem hiding this comment.
One could also argue that it fixes the breakage of wrong PPK1 warnings. ;-)
More seriously: Yes, this is a breaking change and I think bumping the major version for this is fine.
There was a problem hiding this comment.
This make sure we only see PPK kits .... not sure what is breaking here
There was a problem hiding this comment.
We had users selecting the DK and not the PPK kit... this for me fixes that issue ....
| nordicUsb: true, | ||
| nordicDfu: true, | ||
| serialPorts: true, | ||
| jlink: true, |
There was a problem hiding this comment.
Can we also remove serialPorts because we filter to show only devices in DFU boot loader or with the right USB product ID?
No description provided.