Skip to content

Conversation

@datenreisender
Copy link
Contributor

Happens through the update to shared@234. PPK is the app with most dependency events, so hopefully this helps.

Did all updates to shared versions that required changes in separate commits in order to keep the changes as small as possible. Especially the update to shared@231 is quite large because of the formatting changes.

@datenreisender datenreisender added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Oct 23, 2025
@datenreisender datenreisender requested review from Copilot and kylebonnici and removed request for Copilot October 23, 2025 07:23
@github-actions

This comment was marked as resolved.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @nordicsemiconductor/pc-nrfconnect-shared dependency from version 223 to 234 to disable sending dependency telemetry events. The update includes extensive code formatting changes, specifically adding trailing commas to function parameters, object properties, and array elements throughout the codebase to align with the new shared library's formatting requirements.

Key Changes

  • Updated @nordicsemiconductor/pc-nrfconnect-shared dependency from ^223.0.0 to ^234.0.0
  • Applied consistent trailing comma formatting across the entire codebase
  • Minor fixes including assignment operator correction and type refinements

Reviewed Changes

Copilot reviewed 69 out of 70 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
package.json Updated shared library dependency to version 234
worker/serialDevice.js Added trailing commas to function parameters
src/utils/*.ts Applied trailing comma formatting to function parameters and object literals
src/slices/*.ts Added trailing commas to Redux action payload types
src/components/**/*.tsx Applied trailing comma formatting to React components and handlers
src/actions/*.ts Added trailing commas to thunk actions and async functions
src/device/*.ts Applied formatting to device-related code
README.md Reformatted documentation indentation
LICENSE Updated license format with SPDX identifier
Changelog.md Reformatted bullet points for consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Happens through the update to shared@234. PPK is the app with most
dependency events, so hopefully this helps.
@datenreisender datenreisender merged commit 632646d into main Oct 23, 2025
3 checks passed
@datenreisender datenreisender deleted the push-voqxkwpyotku branch October 23, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants