-
Notifications
You must be signed in to change notification settings - Fork 39
Telemetry: Disable sending dependency events #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the @nordicsemiconductor/pc-nrfconnect-shared dependency from version 223 to 234 to disable sending dependency telemetry events. The update includes extensive code formatting changes, specifically adding trailing commas to function parameters, object properties, and array elements throughout the codebase to align with the new shared library's formatting requirements.
Key Changes
- Updated
@nordicsemiconductor/pc-nrfconnect-shareddependency from ^223.0.0 to ^234.0.0 - Applied consistent trailing comma formatting across the entire codebase
- Minor fixes including assignment operator correction and type refinements
Reviewed Changes
Copilot reviewed 69 out of 70 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated shared library dependency to version 234 |
| worker/serialDevice.js | Added trailing commas to function parameters |
| src/utils/*.ts | Applied trailing comma formatting to function parameters and object literals |
| src/slices/*.ts | Added trailing commas to Redux action payload types |
| src/components/**/*.tsx | Applied trailing comma formatting to React components and handlers |
| src/actions/*.ts | Added trailing commas to thunk actions and async functions |
| src/device/*.ts | Applied formatting to device-related code |
| README.md | Reformatted documentation indentation |
| LICENSE | Updated license format with SPDX identifier |
| Changelog.md | Reformatted bullet points for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
47d484d to
da3d577
Compare
Happens through the update to shared@234. PPK is the app with most dependency events, so hopefully this helps.
da3d577 to
6f0f4a2
Compare
Happens through the update to shared@234. PPK is the app with most dependency events, so hopefully this helps.
Did all updates to shared versions that required changes in separate commits in order to keep the changes as small as possible. Especially the update to shared@231 is quite large because of the formatting changes.