Merge pull request #9401 from NuGet/dev

Author: RiadGahlouz

src/AccountDeleter/EmptyFeatureFlagService.cs

@@ -301,6 +301,11 @@ public bool IsDisplayUploadWarningV2Enabled(User user)
             throw new NotImplementedException();
         }
 
+        public bool IsDisplayPackageReadmeWarningEnabled(User user)
+        {
+            throw new NotImplementedException();
+        }
+
         public bool IsFrameworkFilteringEnabled(User user) {
             throw new NotImplementedException();
         }

src/Bootstrap/dist/css/bootstrap-theme.css

@@ -2,8 +2,7 @@
   .readme-container {
     display: block;
     padding: 10.5px;
-    background-color: @pre-bg;
-    border: 1px solid #ccc;
+    border: 2px solid #ccc;
     word-break: normal;
     margin-bottom: @default-margin-bottom;
     overflow: auto;
@@ -44,7 +43,7 @@
 
   pre {
     code.hljs {
-      background-color: #f6f8fa;
+      background-color: @pre-bg;
       color: #24292e; 
 
       .hljs-doctag,
@@ -92,7 +91,7 @@
       .hljs-comment,
       .hljs-code,
       .hljs-formula {
-        color: #6a737d;
+        color: #646d76;
       }
 
       .hljs-name,

src/Bootstrap/less/theme/common-readme.less

@@ -423,6 +423,10 @@
       margin-bottom: -1px;
     }
 
+    .nav-tabs > li.active > a.body-warning-tab > {
+      background-color: #fff4ce;
+    }
+
     .nav-tabs > li > a {
       border-left: 0px;
       border-right: 0px;

src/Bootstrap/less/theme/page-display-package.less

@@ -121,6 +121,7 @@
     }
 
     .tfmTab {
+      display: none;
       max-height: 0;
       overflow: hidden;
       transition: max-height 0.1s ease-out;

src/Bootstrap/less/theme/page-list-packages.less

@@ -135,6 +135,11 @@ public bool IsDisplayUploadWarningV2Enabled(User user)
             throw new NotImplementedException();
         }
 
+        public bool IsDisplayPackageReadmeWarningEnabled(User user)
+        {
+            throw new NotImplementedException();
+        }
+
         public bool IsODataDatabaseReadOnlyEnabled()
         {
             throw new NotImplementedException();

src/GitHubVulnerabilities2Db/Fakes/FakeFeatureFlagService.cs

@@ -48,6 +48,7 @@ public class FeatureFlagService : IFeatureFlagService
         private const string MarkdigMdRenderingFlightName = GalleryPrefix + "MarkdigMdRendering";
         private const string MarkdigMdSyntaxHighlightFlightName = GalleryPrefix + "MarkdigMdSyntaxHighlight";
         private const string DisplayUploadWarningV2FlightName = GalleryPrefix + "DisplayUploadWarningV2";
+        private const string DisplayPackageReadmeWarningFlightName = GalleryPrefix + "DisplayPackageReadmeWarning";
         private const string DeletePackageApiFlightName = GalleryPrefix + "DeletePackageApi";
         private const string ImageAllowlistFlightName = GalleryPrefix + "ImageAllowlist";
         private const string DisplayBannerFlightName = GalleryPrefix + "Banner";
@@ -354,6 +355,11 @@ public bool IsDisplayUploadWarningV2Enabled(User user)
             return _client.IsEnabled(DisplayUploadWarningV2FlightName, user, defaultValue: false);
         }
 
+        public bool IsDisplayPackageReadmeWarningEnabled(User user)
+        {
+            return _client.IsEnabled(DisplayPackageReadmeWarningFlightName, user, defaultValue: false);
+        }
+
         public bool IsDeletePackageApiEnabled(User user)
         {
             return _client.IsEnabled(DeletePackageApiFlightName, user, defaultValue: false);

src/NuGetGallery.Services/Configuration/FeatureFlagService.cs

@@ -278,6 +278,11 @@ public interface IFeatureFlagService
         /// </summary>
         bool IsDisplayUploadWarningV2Enabled(User user);
 
+        /// <summary>
+        /// Whether the new warning of the missing readme is displayed to package authors
+        /// </summary>
+        bool IsDisplayPackageReadmeWarningEnabled(User user);
+
         /// <summary>
         /// Whether or not the user can delete a package through the API.
         /// </summary>

src/NuGetGallery.Services/Configuration/IFeatureFlagService.cs

@@ -15,6 +15,7 @@
         "badges.gitter.im",
         "bettercodehub.com",
         "buildstats.info",
+        "caniuse.bitsofco.de",
         "cdn.jsdelivr.net",
         "cdn.syncfusion.com",
         "ci.appveyor.com",

src/NuGetGallery/App_Data/Files/Content/Trusted-Image-Domains.json

@@ -120,6 +120,12 @@
       "SiteAdmins": false,
       "Accounts": [],
       "Domains": []
+    },
+    "NuGetGallery.DisplayPackageReadmeWarning": {
+      "All": true,
+      "SiteAdmins": false,
+      "Accounts": [],
+      "Domains": []
     }
   }
 }