PhpStan: fix wrong params for explode (#5073)

Author: sreichel

.phpstan.dist.baseline.neon

@@ -3234,12 +3234,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php
 
-		-
-			rawMessage: 'Parameter #2 $string of function explode expects string, array given.'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Eav/Model/Convert/Parser/Abstract.php
-
 		-
 			rawMessage: 'Cannot call method lastInsertId() on Varien_Db_Adapter_Interface|false.'
 			identifier: method.nonObject
@@ -4800,18 +4794,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php
 
-		-
-			rawMessage: 'Parameter #1 $shippingDays of method Mage_Usa_Model_Shipping_Carrier_Dhl_Abstract::_determineShippingDay() expects array, string|false given.'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Abstract.php
-
-		-
-			rawMessage: 'Parameter #2 $string of function explode expects string, array given.'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Abstract.php
-
 		-
 			rawMessage: Access to an undefined property Varien_Object::$domestic.
 			identifier: property.notFound

app/code/core/Mage/Eav/Model/Convert/Parser/Abstract.php

@@ -19,7 +19,7 @@ abstract class Mage_Eav_Model_Convert_Parser_Abstract extends Mage_Dataflow_Mode
     protected $_attributeSetsByName;
 
     /**
-     * @param array $stores
+     * @param string $stores
      * @return array|false
      */
     public function getStoreIds($stores)
@@ -52,7 +52,7 @@ public function getStoreIds($stores)
      */
     public function getStoreCode($storeId)
     {
-        return Mage::app()->getStore($storeId ? $storeId : 0)->getCode();
+        return Mage::app()->getStore($storeId ?: 0)->getCode();
     }
 
     /**
@@ -67,13 +67,13 @@ public function loadAttributeSets($entityTypeId)
         $this->_attributeSetsById = [];
         $this->_attributeSetsByName = [];
         /**
-         * @var int $id
+         * @var int $setId
          * @var Mage_Eav_Model_Entity_Attribute_Set $attributeSet
          */
-        foreach ($attributeSetCollection as $id => $attributeSet) {
+        foreach ($attributeSetCollection as $setId => $attributeSet) {
             $name = $attributeSet->getAttributeSetName();
-            $this->_attributeSetsById[$id] = $name;
-            $this->_attributeSetsByName[$name] = $id;
+            $this->_attributeSetsById[$setId] = $name;
+            $this->_attributeSetsByName[$name] = $setId;
         }
 
         return $this;

app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Abstract.php

@@ -46,7 +46,7 @@ protected function _getShipDate($domestic = true)
     /**
      * Determine shipping day according to configuration settings
      *
-     * @param array $shippingDays
+     * @param string $shippingDays
      * @param string $date
      * @return string
      */
@@ -58,13 +58,13 @@ protected function _determineShippingDay($shippingDays, $date)
 
         $shippingDays = explode(',', $shippingDays);
 
-        $i = 0;
+        $index = 0;
         $weekday = date('D', strtotime($date));
-        while (!in_array($weekday, $shippingDays) && $i < 10) {
-            $i++;
-            $weekday = date('D', strtotime("$date +$i day"));
+        while (!in_array($weekday, $shippingDays) && $index < 10) {
+            $index++;
+            $weekday = date('D', strtotime("$date +$index day"));
         }
 
-        return date(self::REQUEST_DATE_FORMAT, strtotime("$date +$i day"));
+        return date(self::REQUEST_DATE_FORMAT, strtotime("$date +$index day"));
     }
 }