RWD theme: use jQuery via composer (#4429)

* removed jquery-files

* updated xml layout, added config

* test composer plugin

* update jquery

* updated config scope

* Downgraded to 1.12.4

* phpstan baseline

Author: sreichel

.gitignore

@@ -26,6 +26,9 @@
 # ChartJs library
 /js/lib/chartjs
 
+# jQuery library
+/js/lib/jquery/jquery*
+
 # TinyMCE library
 /js/lib/tinymce
 

.phpstan.dist.baseline.neon

@@ -1140,6 +1140,12 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Api2/Model/Resource.php
 
+		-
+			message: '#^Call to an undefined method Varien_Data_Collection_Db\:\:addAttributeToFilter\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: app/code/core/Mage/Api2/Model/Resource.php
+
 		-
 			message: '#^Method Mage_Api2_Model_Resource\:\:_create\(\) invoked with 1 parameter, 0 required\.$#'
 			identifier: arguments.count
@@ -6117,7 +6123,7 @@ parameters:
 		-
 			message: '#^If condition is always false\.$#'
 			identifier: if.alwaysFalse
-			count: 2
+			count: 3
 			path: app/code/core/Mage/Tax/Helper/Data.php
 
 		-

app/code/core/Mage/Core/etc/config.xml

@@ -310,6 +310,9 @@
             <js>
                 <merge_files>0</merge_files>
             </js>
+            <jquery>
+                <migrate>0</migrate>
+            </jquery>
         </dev>
         <system>
             <csrf>

app/code/core/Mage/Core/etc/system.xml

@@ -725,6 +725,24 @@
                         </merge_css_files>
                     </fields>
                 </css>
+                <jquery translate="label">
+                    <label>jQuery Settings</label>
+                    <sort_order>120</sort_order>
+                    <show_in_default>1</show_in_default>
+                    <show_in_website>1</show_in_website>
+                    <show_in_store>1</show_in_store>
+                    <fields>
+                        <migrate translate="label">
+                            <label>Load jQuery-migration.js</label>
+                            <frontend_type>select</frontend_type>
+                            <source_model>adminhtml/system_config_source_yesno</source_model>
+                            <sort_order>10</sort_order>
+                            <show_in_default>1</show_in_default>
+                            <show_in_website>1</show_in_website>
+                            <show_in_store>1</show_in_store>
+                        </migrate>
+                    </fields>
+                </jquery>
             </groups>
         </dev>
         <general translate="label" module="core">

app/design/frontend/rwd/default/layout/page.xml

@@ -25,7 +25,10 @@
 
             <block type="page/html_head" name="head" as="head">
                 <action method="addJs"><script>prototype/prototype.js</script></action>
-                <action method="addJs"><script>lib/jquery/jquery-1.12.4.min.js</script></action>
+                <action method="addJs"><script>lib/jquery/jquery.min.js</script></action>
+                <action method="addJs" ifconfig="dev/jquery/migrate">
+                    <script>lib/jquery/jquery-migrate.min.js</script>
+                </action>
                 <action method="addJs"><script>lib/jquery/noconflict.js</script></action>
                 <action method="addJs"><script>lib/ccard.js</script></action>
                 <action method="addJs"><script>prototype/validation.js</script></action>

composer.json

@@ -28,6 +28,7 @@
         "composer-runtime-api": "^2",
         "colinmollenhour/cache-backend-redis": "^1.14",
         "colinmollenhour/magento-redis-session": "^3.2.0",
+        "components/jquery": "1.12.4",
         "cweagans/composer-patches": "^1.7",
         "ezyang/htmlpurifier": "^4.17",
         "flowjs/flowjs": "dev-master",