Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 1, 2025

Copilot AI review requested due to automatic review settings November 1, 2025 07:12
@sreichel sreichel added the chore label Nov 1, 2025
@github-actions github-actions bot added Component: CatalogRule Relates to Mage_CatalogRule Component: SalesRule Relates to Mage_SalesRule Component: Rule Relates to Mage_Rule php-cs-fixer labels Nov 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes PHPDoc annotations to follow the correct format where the type comes before the variable name, enforced by enabling the phpdoc_var_annotation_correct_order rule in PHP-CS-Fixer. This addresses inconsistent PHPDoc formatting across the codebase.

Key changes:

  • Enabled phpdoc_var_annotation_correct_order rule in PHP-CS-Fixer configuration
  • Updated @var annotations to place type before variable/expression in three Observer files
  • Added @throws Throwable documentation to a method signature

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.php-cs-fixer.dist.php Enabled phpdoc_var_annotation_correct_order rule for consistent PHPDoc formatting
app/code/core/Mage/SalesRule/Model/Observer.php Fixed @var annotation order and added @throws documentation
app/code/core/Mage/CatalogRule/Model/Observer.php Fixed @var annotation order for inline type hints
app/code/core/Mage/Rule/Model/Condition/Combine.php Updated @return types from array to Mage_Rule_Model_Condition_Combine

@sreichel sreichel force-pushed the cleanup/phpdoc_var_annotation_correct_order branch from b248fe0 to af0747d Compare November 1, 2025 07:24
@sreichel sreichel merged commit 66855b4 into OpenMage:main Nov 2, 2025
20 checks passed
@sreichel sreichel deleted the cleanup/phpdoc_var_annotation_correct_order branch November 2, 2025 05:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Component: CatalogRule Relates to Mage_CatalogRule Component: Rule Relates to Mage_Rule Component: SalesRule Relates to Mage_SalesRule php-cs-fixer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant