Improved Mage_Catalog_Model_Product_Image::setSize()

[sreichel]

In Mage_Catalog_Model_Product_Image::setSize($size) the $size parameter had to be a string value, seperated by a x for width and heigth.

Everything else leads to undifined offset 1 error.

Also, for phpstan (or later strict_types) extracted dimensions had to be integer values, no strings.

Refactored setSize() to deal with different values.

• 100x100 (default required pattern)
• 100x and x100 for setting one dimension
• 100 for both dimensions
• added test

[Copilot]

Pull Request Overview

This PR refactors the setSize() method in the Mage_Catalog_Model_Product_Image class to handle edge cases better and adds comprehensive unit tests. The refactored logic handles empty strings, zero values, and various dimension formats more consistently.

• Improved the setSize() method to handle edge cases like empty strings, "0x", "x0", and non-numeric values
• Added unit tests with comprehensive test coverage for different size format inputs
• Fixed PHPStan type errors by updating parameter type hints

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
tests/unit/Traits/DataProvider/Mage/Catalog/Model/Product/ImageTrait.php	New trait providing test data for various size format inputs
tests/unit/Mage/Catalog/Model/Product/ImageTest.php	New unit test file testing the setSize() method with data provider
app/code/core/Mage/Catalog/Model/Product/Image.php	Refactored setSize() method with improved edge case handling and updated type hints
.phpstan.dist.baseline.neon	Removed 3 PHPStan errors that are now fixed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud