-
Notifications
You must be signed in to change notification settings - Fork 242
chore: dotnet targets #3791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Seddryck
wants to merge
28
commits into
PRQL:main
Choose a base branch
from
Seddryck:dotnet-targets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: dotnet targets #3791
Changes from 15 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6864fe0
chore: add edition settings
Seddryck de79628
build: move build settings to props and targets
Seddryck b9d82c3
refactor: improve function descriptions and exception messages
Seddryck bc12ed9
fix: update name of the native dll to import
Seddryck 2f85dc0
refactor: make PrqlCompilerOptions immutable
Seddryck eca84f5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a2c124d
Merge branch 'PRQL:main' into dotnet-targets
Seddryck 891c704
Merge branch 'main' into dotnet-targets
max-sixty 800f541
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ae0aa9f
ci: github-action for building, testing and packaging in .NET
Seddryck 235951e
fix: explicitely run the script setting the version
Seddryck bada233
fix: syntax issue
Seddryck fe70d3a
fix: cargo invocation
Seddryck e67b2c7
fix: new attempt
Seddryck ab70454
fix: finally understood that default shell is powershell :-/
Seddryck 4357236
style: switch to file-scoped namespace
Seddryck 3765846
fix: no clue
Seddryck 0343340
fix: change jq
Seddryck c7c6d4f
fix: add reference to GitHubActionsTestLogger
Seddryck d60c635
fix: package command for CMD shell
Seddryck edb5735
style: fix trailing spaces reported by linter
Seddryck 003c1cd
fix: attemp to make package downloadable to check it
Seddryck 7bca705
style: prettier test-dotnet.yaml
Seddryck 1092829
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 18c0bb4
Merge branch 'main' into dotnet-targets
Seddryck d767684
refactor: try to use the bash script
Seddryck b30c3ee
Merge branch 'dotnet-targets' of https://github.com/Seddryck/prql int…
Seddryck 1bb0ca4
style: switch end of line to lf to match with .gitignore
Seddryck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,175 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| root = true | ||
|
|
||
| # Default settings: | ||
| # A newline ending every file | ||
| # Use 4 spaces as indentation | ||
| [*] | ||
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 4 | ||
| trim_trailing_whitespace = true | ||
| dotnet_style_operator_placement_when_wrapping = beginning_of_line | ||
| tab_width = 4 | ||
| end_of_line = crlf | ||
eitsupi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # C# files | ||
| [*.cs] | ||
| # New line preferences | ||
| csharp_new_line_before_open_brace = all | ||
| csharp_new_line_before_else = true | ||
| csharp_new_line_before_catch = true | ||
| csharp_new_line_before_finally = true | ||
| csharp_new_line_before_members_in_object_initializers = true | ||
| csharp_new_line_before_members_in_anonymous_types = true | ||
| csharp_new_line_between_query_expression_clauses = true | ||
|
|
||
| # Indentation preferences | ||
| csharp_indent_block_contents = true | ||
| csharp_indent_braces = false | ||
| csharp_indent_case_contents = true | ||
| csharp_indent_case_contents_when_block = true | ||
| csharp_indent_switch_labels = true | ||
| csharp_indent_labels = one_less_than_current | ||
|
|
||
| # Modifier preferences | ||
| csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion | ||
|
|
||
| # avoid this. unless absolutely necessary | ||
| dotnet_style_qualification_for_field = false:suggestion | ||
| dotnet_style_qualification_for_property = false:suggestion | ||
| dotnet_style_qualification_for_method = false:suggestion | ||
| dotnet_style_qualification_for_event = false:suggestion | ||
|
|
||
| # Types: use keywords instead of BCL types, and permit var only when the type is clear | ||
| csharp_style_var_for_built_in_types = true:none | ||
| csharp_style_var_when_type_is_apparent = true:suggestion | ||
| csharp_style_var_elsewhere = true:suggestion | ||
| dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion | ||
| dotnet_style_predefined_type_for_member_access = true:suggestion | ||
|
|
||
| # name all constant fields using PascalCase | ||
| dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion | ||
| dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields | ||
| dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style | ||
| dotnet_naming_symbols.constant_fields.applicable_kinds = field | ||
| dotnet_naming_symbols.constant_fields.required_modifiers = const | ||
| dotnet_naming_style.pascal_case_style.capitalization = pascal_case | ||
|
|
||
| # static fields should have s_ prefix | ||
| dotnet_naming_rule.static_fields_should_have_prefix.severity = suggestion | ||
| dotnet_naming_rule.static_fields_should_have_prefix.symbols = static_fields | ||
| dotnet_naming_rule.static_fields_should_have_prefix.style = static_prefix_style | ||
| dotnet_naming_symbols.static_fields.applicable_kinds = none | ||
| dotnet_naming_symbols.static_fields.required_modifiers = static | ||
| dotnet_naming_symbols.static_fields.applicable_accessibilities = private, internal, private_protected | ||
| dotnet_naming_style.static_prefix_style.required_prefix = s_ | ||
| dotnet_naming_style.static_prefix_style.capitalization = camel_case | ||
|
|
||
| # internal and private fields should be _camelCase | ||
| dotnet_naming_rule.camel_case_for_private_internal_fields.severity = suggestion | ||
| dotnet_naming_rule.camel_case_for_private_internal_fields.symbols = private_internal_fields | ||
| dotnet_naming_rule.camel_case_for_private_internal_fields.style = camel_case_style | ||
| dotnet_naming_symbols.private_internal_fields.applicable_kinds = field | ||
| dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal | ||
| dotnet_naming_style.camel_case_style.capitalization = camel_case | ||
|
|
||
| # Code style defaults | ||
| csharp_using_directive_placement = outside_namespace:suggestion | ||
| dotnet_sort_system_directives_first = true | ||
| csharp_prefer_braces = true:silent | ||
| csharp_preserve_single_line_blocks = true:none | ||
| csharp_preserve_single_line_statements = false:none | ||
| csharp_prefer_static_local_function = true:suggestion | ||
| csharp_prefer_simple_using_statement = false:none | ||
| csharp_style_prefer_switch_expression = true:suggestion | ||
|
|
||
| # Code quality | ||
| dotnet_style_readonly_field = true:suggestion | ||
| dotnet_code_quality_unused_parameters = non_public:suggestion | ||
|
|
||
| # Expression-level preferences | ||
| dotnet_style_object_initializer = true:suggestion | ||
| dotnet_style_collection_initializer = true:suggestion | ||
| dotnet_style_explicit_tuple_names = true:suggestion | ||
| dotnet_style_coalesce_expression = true:suggestion | ||
| dotnet_style_null_propagation = true:suggestion | ||
| dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion | ||
| dotnet_style_prefer_inferred_tuple_names = true:suggestion | ||
| dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion | ||
| dotnet_style_prefer_auto_properties = true:suggestion | ||
| dotnet_style_prefer_conditional_expression_over_assignment = true:refactoring | ||
| dotnet_style_prefer_conditional_expression_over_return = true:refactoring | ||
| csharp_prefer_simple_default_expression = true:suggestion | ||
|
|
||
| # Expression-bodied members | ||
| csharp_style_expression_bodied_methods = true:silent | ||
| csharp_style_expression_bodied_constructors = true:silent | ||
| csharp_style_expression_bodied_operators = true:silent | ||
| csharp_style_expression_bodied_properties = true:silent | ||
| csharp_style_expression_bodied_indexers = true:silent | ||
| csharp_style_expression_bodied_accessors = true:silent | ||
| csharp_style_expression_bodied_lambdas = true:refactoring | ||
| csharp_style_expression_bodied_local_functions = true:refactoring | ||
|
|
||
| # Pattern matching | ||
| csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion | ||
| csharp_style_pattern_matching_over_as_with_null_check = true:suggestion | ||
| csharp_style_inlined_variable_declaration = true:suggestion | ||
|
|
||
| # Null checking preferences | ||
| csharp_style_throw_expression = true:suggestion | ||
| csharp_style_conditional_delegate_call = true:suggestion | ||
|
|
||
| # Other features | ||
| csharp_style_prefer_index_operator = false:none | ||
| csharp_style_prefer_range_operator = false:none | ||
| csharp_style_pattern_local_over_anonymous_function = false:none | ||
|
|
||
| # Space preferences | ||
| csharp_space_after_cast = false | ||
| csharp_space_after_colon_in_inheritance_clause = true | ||
| csharp_space_after_comma = true | ||
| csharp_space_after_dot = false | ||
| csharp_space_after_keywords_in_control_flow_statements = true | ||
| csharp_space_after_semicolon_in_for_statement = true | ||
| csharp_space_around_binary_operators = before_and_after | ||
| csharp_space_around_declaration_statements = do_not_ignore | ||
| csharp_space_before_colon_in_inheritance_clause = true | ||
| csharp_space_before_comma = false | ||
| csharp_space_before_dot = false | ||
| csharp_space_before_open_square_brackets = false | ||
| csharp_space_before_semicolon_in_for_statement = false | ||
| csharp_space_between_empty_square_brackets = false | ||
| csharp_space_between_method_call_empty_parameter_list_parentheses = false | ||
| csharp_space_between_method_call_name_and_opening_parenthesis = false | ||
| csharp_space_between_method_call_parameter_list_parentheses = false | ||
| csharp_space_between_method_declaration_empty_parameter_list_parentheses = false | ||
| csharp_space_between_method_declaration_name_and_open_parenthesis = false | ||
| csharp_space_between_method_declaration_parameter_list_parentheses = false | ||
| csharp_space_between_parentheses = false | ||
| csharp_space_between_square_brackets = false | ||
| csharp_style_namespace_declarations = block_scoped:silent | ||
| csharp_style_prefer_method_group_conversion = true:silent | ||
| csharp_style_prefer_top_level_statements = true:silent | ||
| csharp_style_prefer_primary_constructors = false:suggestion | ||
|
|
||
| # Xml project files | ||
| [*.{csproj,props,targets}] | ||
| indent_size = 2 | ||
| charset = utf-8 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.