Skip to content

Conversation

@EtienneM
Copy link
Member

@EtienneM EtienneM commented Dec 23, 2024

Fix #92

Negroni is only used to call negroni.NewResponseWriter. The changelog (https://github.com/urfave/negroni/blob/master/CHANGELOG.md) does not mention anything about this.

  • Add a changelog entry in the CHANGELOG.md file, in the "To be Released" section.
  • As much as possible, do not deprecate parameters. Only add new parameters.

@EtienneM EtienneM self-assigned this Dec 23, 2024
@EtienneM EtienneM marked this pull request as ready for review December 23, 2024 10:35
@EtienneM EtienneM enabled auto-merge December 23, 2024 10:35
@EtienneM EtienneM requested a review from ipfaze December 23, 2024 10:36
Copy link

@ipfaze ipfaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@EtienneM EtienneM merged commit 4762f60 into master Dec 23, 2024
3 checks passed
@EtienneM EtienneM deleted the feat/92/negroni_v3 branch December 23, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LoggingMiddleware] Update github.com/urfave/negroni from v1 to v3

3 participants