fix: fail non-200 codes

Author: cirex-web

env.ts

@@ -3,11 +3,26 @@ import * as dotenv from "dotenv";
 
 dotenv.config(); // loads in .env file if present
 console.log(process.env);
+export interface ISiteTrackingInfo {
+  url: string;
+  doNotPing: boolean;
+}
 const envSchema = z.object({
   SLACK_APP_TOKEN: z.string(),
   SLACK_BOT_TOKEN: z.string(),
   CMUEATS_CHANNEL_ID: z.string(),
-  MONITORED_URLS: z.string().transform((str) => str.split(",")),
+  MONITORED_URLS: z.string().transform((str) =>
+    str.split(",").map((site) => {
+      const [url, ignore] = site.split("|");
+      if (ignore !== undefined) {
+        console.log("Not pinging", url);
+      }
+      return {
+        url,
+        doNotPing: ignore !== undefined,
+      } satisfies ISiteTrackingInfo;
+    })
+  ),
   /** Number of ms between pings on the same site */
   MONITOR_INTERVAL_MS: z.coerce.number().default(10000),
   /** Timeout for a single ping */

intervals/siteMonitor.ts

@@ -1,5 +1,5 @@
 import { DateTime } from "luxon";
-import { env } from "../env";
+import { env, ISiteTrackingInfo } from "../env";
 
 interface SiteData {
   downState?: {
@@ -12,22 +12,24 @@ interface SiteData {
 }
 export class SiteMonitor {
   siteStatus: Record<string, SiteData> = {};
+  doNotPing: Record<string, boolean> = {};
   sendMessage: (msg: string) => void;
   startupTime = DateTime.local({ zone: "America/New_York" });
   alertThresholdMs: number;
   pingThresholdMs: number;
 
   constructor(
-    sites: string[],
+    sites: ISiteTrackingInfo[],
     sendMessage: (msg: string) => void,
     alertThresholdMs: number,
     pingThresholdMs: number
   ) {
-    for (const siteUrl of sites) {
-      this.siteStatus[siteUrl] = {
+    for (const site of sites) {
+      this.siteStatus[site.url] = {
         successfulFetchCount: 0,
         failedFetchCount: 0,
       };
+      this.doNotPing[site.url] = site.doNotPing;
     }
     this.sendMessage = sendMessage;
     this.alertThresholdMs = alertThresholdMs;
@@ -60,13 +62,14 @@ export class SiteMonitor {
     }
     if (
       +new Date() - downState.firstDownTimestamp >= this.pingThresholdMs &&
-      downState.alertStage === "WARNED"
+      downState.alertStage === "WARNED" &&
+      !this.doNotPing[siteUrl]
     ) {
       downState.alertStage = "PINGED";
       this.sendMessage(
         `<!channel>! ${siteUrl} has been down for the past ${
           this.pingThresholdMs / 1000
-        } seconds with the following errors: ${downState.failErrors.join(", ")}`
+        } seconds with ${downState.failErrors.length} errors`
       );
     }
   }

intervals/uptimeChecker.ts

@@ -10,7 +10,10 @@ const checkSite = (
 ) => {
   console.log(`Running check for ${url}`);
   fetch(url, { signal: AbortSignal.timeout(env.URL_TIMEOUT_MS) })
-    .then(onSuccess)
+    .then((res) => {
+      if (res.status !== 200) onError(res);
+      else onSuccess(res);
+    })
     .catch(onError);
 };
 
@@ -26,14 +29,14 @@ export const setUpUptimeChecker = (
   setInterval(() => {
     env.MONITORED_URLS.forEach((site) =>
       checkSite(
-        site,
+        site.url,
         (error) => {
-          console.log(`check failed for ${site}`, error);
-          siteMonitor?.siteDown(site, error);
+          console.log(`check failed for ${site.url}`, error);
+          siteMonitor?.siteDown(site.url, error);
         },
-        () => {
-          console.log(`check successful for ${site}`);
-          siteMonitor?.siteUp(site);
+        (res) => {
+          console.log(`check successful for ${site.url}`);
+          siteMonitor?.siteUp(site.url);
         }
       )
     );