Merge pull request #1951 from Shopify/actual-revert

Fully revert calling to_s on filter array

Author: Maaarcocr

lib/liquid/standardfilters.rb

@@ -982,8 +982,6 @@ def filter_array(input, property, target_value, default_value = [], &block)
 
       return default_value if ary.empty?
 
-      property = Utils.to_s(property)
-
       block.call(ary) do |item|
         if target_value.nil?
           item[property]

lib/liquid/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Liquid
-  VERSION = "5.8.5"
+  VERSION = "5.8.6"
 end

test/integration/standard_filter_test.rb

@@ -1054,10 +1054,11 @@ def test_where_with_empty_string_is_a_no_op
 
   def test_where_with_nil_is_a_no_op
     environment = { "array" => ["alpha", "beta", "gamma"] }
-    expected_output = "alpha beta gamma"
     template = "{{ array | where: nil | join: ' ' }}"
 
-    assert_template_result(expected_output, template, environment)
+    assert_raises(Liquid::ArgumentError) do
+      assert_template_result("alpha beta gamma", template, environment)
+    end
   end
 
   def test_where_with_value