Try again.

Author: JimBobSquarePants

.github/workflows/build-and-test.yml

@@ -14,22 +14,25 @@ on:
     types: [ labeled, opened, synchronize, reopened ]
 
 jobs:
-  # Warm up LFS cache once, on a single runner, and compute a stable cache key
+  # Prime a single LFS cache and expose the exact key for the matrix
   WarmLFS:
     runs-on: ubuntu-latest
-
-    # Expose the computed cache key so matrix jobs can use it
     outputs:
-      lfs_key: ${{ steps.compute-key.outputs.lfs_key }}
-
+      lfs_key: ${{ steps.expose-key.outputs.lfs_key }}
     steps:
-      # Checkout repo with full history and submodules so we can see all LFS files
-      - uses: actions/checkout@v4
+      - name: Git Config
+        shell: bash
+        run: |
+          git config --global core.autocrlf false
+          git config --global core.longpaths true
+
+      - name: Git Checkout
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
 
-      # Create a deterministic list of LFS object IDs:
+      # Deterministic list of LFS object IDs, then compute a portable key:
       # - `git lfs ls-files -l` lists all tracked LFS objects with their SHA-256
       # - `awk '{print $1}'` extracts just the SHA field
       # - `sort` sorts in byte order (hex hashes sort the same everywhere)
@@ -38,30 +41,25 @@ jobs:
         shell: bash
         run: git lfs ls-files -l | awk '{print $1}' | sort > .lfs-assets-id
 
-      # Compute a stable cache key by hashing the list file itself.
-      # This guarantees the same key across all OSes and all matrix jobs.
-      - name: Git Compute LFS cache key
-        id: compute-key
+      - name: Git Expose LFS cache key
+        id: expose-key
         shell: bash
-        run: |
-          # sha256sum outputs "<hash>  <filename>"
-          KEY_HASH=$(sha256sum .lfs-assets-id | awk '{print $1}')
-          echo "lfs_key=lfs-${KEY_HASH}-v1" >> "$GITHUB_OUTPUT"
+        env:
+          LFS_KEY: lfs-${{ hashFiles('.lfs-assets-id') }}-v1
+        run: echo "lfs_key=$LFS_KEY" >> "$GITHUB_OUTPUT"
 
-      # Restore or populate the cache for .git/lfs using the computed key
       - name: Git Setup LFS Cache
         uses: actions/cache@v4
         with:
           path: .git/lfs
-          key: ${{ steps.compute-key.outputs.lfs_key }}
+          key: ${{ steps.expose-key.outputs.lfs_key }}
 
-      # Ensure all LFS files for this commit are present locally
       - name: Git Pull LFS
         shell: bash
         run: git lfs pull
 
   Build:
-    needs: WarmLFS # Ensure the cache and id file exist before starting the matrix
+    needs: WarmLFS
     strategy:
       matrix:
         isARM:
@@ -123,8 +121,8 @@ jobs:
       - name: Install libgdi+, which is required for tests running on ubuntu
         if: ${{ contains(matrix.options.os, 'ubuntu') }}
         run: |
-            sudo apt-get update
-            sudo apt-get -y install libgdiplus libgif-dev libglib2.0-dev libcairo2-dev libtiff-dev libexif-dev
+          sudo apt-get update
+          sudo apt-get -y install libgdiplus libgif-dev libglib2.0-dev libcairo2-dev libtiff-dev libexif-dev
 
       - name: Git Config
         shell: bash
@@ -138,21 +136,15 @@ jobs:
           fetch-depth: 0
           submodules: recursive
 
-      # Use the *exact same key* computed in WarmLFS to restore the warmed cache.
-      # This avoids regenerating the key per-OS and ensures all matrix jobs hit the same cache.
-      - uses: actions/cache@v4
-        with:
-          path: .git/lfs
-          key: ${{ needs.WarmLFS.outputs.lfs_key }}
-
+      # Use the warmed key from WarmLFS. Do not recompute or recreate .lfs-assets-id here.
       - name: Git Setup LFS Cache
         uses: actions/cache@v4
-        id: lfs-cache
         with:
           path: .git/lfs
-          key: lfs-${{ hashFiles('.lfs-assets-id') }}-v1
+          key: ${{ needs.WarmLFS.outputs.lfs_key }}
 
       - name: Git Pull LFS
+        shell: bash
         run: git lfs pull
 
       - name: NuGet Install
@@ -183,29 +175,29 @@ jobs:
       - name: DotNet Build
         if: ${{ matrix.options.sdk-preview != true }}
         shell: pwsh
-        run: ./ci-build.ps1 "${{ matrix.options.framework }}"
+        run: ./ci-build.ps1 "${{matrix.options.framework}}"
         env:
           SIXLABORS_TESTING: True
 
       - name: DotNet Build Preview
         if: ${{ matrix.options.sdk-preview == true }}
         shell: pwsh
-        run: ./ci-build.ps1 "${{ matrix.options.framework }}"
+        run: ./ci-build.ps1 "${{matrix.options.framework}}"
         env:
           SIXLABORS_TESTING_PREVIEW: True
 
       - name: DotNet Test
         if: ${{ matrix.options.sdk-preview != true }}
         shell: pwsh
-        run: ./ci-test.ps1 "${{ matrix.options.os }}" "${{ matrix.options.framework }}" "${{ matrix.options.runtime }}" "${{ matrix.options.codecov }}"
+        run: ./ci-test.ps1 "${{matrix.options.os}}" "${{matrix.options.framework}}" "${{matrix.options.runtime}}" "${{matrix.options.codecov}}"
         env:
           SIXLABORS_TESTING: True
           XUNIT_PATH: .\tests\ImageSharp.Tests # Required for xunit
 
       - name: DotNet Test Preview
         if: ${{ matrix.options.sdk-preview == true }}
         shell: pwsh
-        run: ./ci-test.ps1 "${{ matrix.options.os }}" "${{ matrix.options.framework }}" "${{ matrix.options.runtime }}" "${{ matrix.options.codecov }}"
+        run: ./ci-test.ps1 "${{matrix.options.os}}" "${{matrix.options.framework}}" "${{matrix.options.runtime}}" "${{matrix.options.codecov}}"
         env:
           SIXLABORS_TESTING_PREVIEW: True
           XUNIT_PATH: .\tests\ImageSharp.Tests # Required for xunit
@@ -219,11 +211,8 @@ jobs:
 
   Publish:
     needs: [Build]
-
     runs-on: ubuntu-latest
-
     if: (github.event_name == 'push')
-
     steps:
       - name: Git Config
         shell: bash

.github/workflows/code-coverage.yml

@@ -36,7 +36,7 @@ jobs:
           fetch-depth: 0
           submodules: recursive
 
-      # Create a deterministic list of LFS object IDs:
+      # Deterministic list of LFS object IDs, then compute a portable key:
       # - `git lfs ls-files -l` lists all tracked LFS objects with their SHA-256
       # - `awk '{print $1}'` extracts just the SHA field
       # - `sort` sorts in byte order (hex hashes sort the same everywhere)