Merge pull request #335 from pgporada/fix-race-condition

ggongaware · web-flow · commit 2f095f0e6bb9 · 2021-04-28T14:42:19.000-07:00
Fix race condition in nextVmId
diff --git a/proxmox/provider.go b/proxmox/provider.go
@@ -168,12 +168,12 @@ func getClient(pm_api_url string, pm_user string, pm_password string, pm_otp str
 
 func nextVmId(pconf *providerConfiguration) (nextId int, err error) {
 	pconf.Mutex.Lock()
+	defer pconf.Mutex.Unlock()
 	pconf.MaxVMID, err = pconf.Client.GetNextID(pconf.MaxVMID + 1)
 	if err != nil {
 		return 0, err
 	}
 	nextId = pconf.MaxVMID
-	pconf.Mutex.Unlock()
 	return nextId, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -168,12 +168,12 @@ func getClient(pm_api_url string, pm_user string, pm_password string, pm_otp str`
`168`	`168`
`169`	`169`	`func nextVmId(pconf *providerConfiguration) (nextId int, err error) {`
`170`	`170`	`pconf.Mutex.Lock()`
	`171`	`+ defer pconf.Mutex.Unlock()`
`171`	`172`	`pconf.MaxVMID, err = pconf.Client.GetNextID(pconf.MaxVMID + 1)`
`172`	`173`	`if err != nil {`
`173`	`174`	`return 0, err`
`174`	`175`	`}`
`175`	`176`	`nextId = pconf.MaxVMID`
`176`		`- pconf.Mutex.Unlock()`
`177`	`177`	`return nextId, nil`
`178`	`178`	`}`
`179`	`179`