Spam ban: Fix tests (#755)

Feature works in prod, just test mock was incomplete.
Formatting fixed and method casing kept consistent.

Author: Mclilzee

services/spam-ban/__snapshots__/spam-banning.service.test.js.snap

@@ -81,7 +81,6 @@ exports[`Banning spammer in automod channel Ban user if in the automod channel 2
 {
   "content": "Successfully banned <@123> for spam.",
   "flags": 64,
-
 }
 `;
 
@@ -166,7 +165,6 @@ exports[`Banning spammer in other channels Bans user and deletes their messages
 
 exports[`Banning spammer in other channels Bans user and does not delete their messages if keep message button clicked 1`] = `
 {
-
   "deleteMessageSeconds": 0,
   "reason": "Account is compromised",
 }

services/spam-ban/spam-banning.service.js

@@ -1,4 +1,3 @@
-
 const {
   EmbedBuilder,
   ButtonBuilder,
@@ -25,7 +24,7 @@ class SpamBanningService {
 
     if (message.channelId !== config.channels.automodBlockChannelId) {
       const response =
-        await SpamBanningService.#AskForDeleteMessages(interaction);
+        await SpamBanningService.#askForDeleteMessages(interaction);
 
       if (response.result === 'cancel') {
         await interaction.editReply({
@@ -81,7 +80,7 @@ class SpamBanningService {
     }
   }
 
-  static async #AskForDeleteMessages(interaction) {
+  static async #askForDeleteMessages(interaction) {
     const keepMessages = new ButtonBuilder()
       .setCustomId('keepMessages')
       .setLabel("Don't delete messages")
@@ -111,18 +110,19 @@ class SpamBanningService {
     });
 
     try {
-      const buttonInteraction = await response.resource.message.awaitMessageComponent({ time: 60_000 });
-  
+      const buttonInteraction =
+        await response.resource.message.awaitMessageComponent({ time: 60_000 });
+
       // Handle the button interaction
       if (buttonInteraction.customId === 'cancel') {
-      await buttonInteraction.update({
-        content: 'Action has been cancelled.',
-        components: [],
-      });
-    } else {
-      // Acknowledge the button press but don't change the message yet
-      await buttonInteraction.deferUpdate();
-    }
+        await buttonInteraction.update({
+          content: 'Action has been cancelled.',
+          components: [],
+        });
+      } else {
+        // Acknowledge the button press but don't change the message yet
+        await buttonInteraction.deferUpdate();
+      }
       return { result: buttonInteraction.customId };
     } catch {
       return { result: 'timeout' };
@@ -143,10 +143,12 @@ class SpamBanningService {
     } else {
       reply = `Banned <@${message.author.id}> for spam but wasn't able to contact the user as they have left the server.`;
     }
+
     await guild.members.ban(message.author.id, {
       reason: 'Account is compromised',
       deleteMessageSeconds: deleteMessages ? 60 * 60 * 24 * 7 : 0,
     });
+
     return reply;
   }
 

services/spam-ban/spam-banning.service.test.js

@@ -22,12 +22,19 @@ function createInteractionMock(message, guild) {
     reply: jest.fn((arg) => {
       replyArg = arg;
       return {
-        awaitMessageComponent: jest.fn(() => {
-          if (messageComponentReturn === 'timeout') {
-            return Promise.reject();
-          }
-          return Promise.resolve({ customId: messageComponentReturn });
-        }),
+        resource: {
+          message: {
+            awaitMessageComponent: () => {
+              if (messageComponentReturn === 'timeout') {
+                return Promise.reject();
+              }
+              return Promise.resolve({
+                customId: messageComponentReturn,
+                deferUpdate: () => {},
+              });
+            },
+          },
+        },
       };
     }),
     guild,
@@ -130,8 +137,7 @@ describe('Banning spammer in automod channel', () => {
 
   it('Ban user if in the automod channel', async () => {
     await SpamBanningService.handleInteraction(interactionMock);
-    await SpamBanningService.handleInteraction(interactionMock);
-    // expect(interactionMock.guild.members.ban).toHaveBeenCalledTimes(1);
+    expect(interactionMock.guild.members.ban).toHaveBeenCalledTimes(1);
     expect(interactionMock.getBanArg()).toMatchSnapshot();
     expect(interactionMock.getReplyArg()).toMatchSnapshot();
   });