rename keep option

Author: Asartea

services/spam-ban/__snapshots__/spam-banning.service.test.js.snap

@@ -90,7 +90,7 @@ exports[`Banning spammer in other channels Asks for confirmation if not in autom
     {
       "components": [
         {
-          "custom_id": "dontDeleteMessages",
+          "custom_id": "keepMessages",
           "emoji": undefined,
           "label": "Don't delete messages",
           "style": 4,
@@ -116,7 +116,7 @@ exports[`Banning spammer in other channels Asks for confirmation if not in autom
   ],
   "content": "Would you like to delete messages from the user being banned?",
   "ephemeral": true,
-  "withReponse": true,
+  "withResponse": true,
 }
 `;
 
@@ -133,7 +133,7 @@ exports[`Banning spammer in other channels Bans user and deletes their messages
     {
       "components": [
         {
-          "custom_id": "dontDeleteMessages",
+          "custom_id": "keepMessages",
           "emoji": undefined,
           "label": "Don't delete messages",
           "style": 4,
@@ -159,7 +159,7 @@ exports[`Banning spammer in other channels Bans user and deletes their messages
   ],
   "content": "Would you like to delete messages from the user being banned?",
   "ephemeral": true,
-  "withReponse": true,
+  "withResponse": true,
 }
 `;
 
@@ -176,7 +176,7 @@ exports[`Banning spammer in other channels Bans user and does not delete their m
     {
       "components": [
         {
-          "custom_id": "dontDeleteMessages",
+          "custom_id": "keepMessages",
           "emoji": undefined,
           "label": "Don't delete messages",
           "style": 4,
@@ -202,7 +202,7 @@ exports[`Banning spammer in other channels Bans user and does not delete their m
   ],
   "content": "Would you like to delete messages from the user being banned?",
   "ephemeral": true,
-  "withReponse": true,
+  "withResponse": true,
 }
 `;
 
@@ -212,7 +212,7 @@ exports[`Banning spammer in other channels Cancels the action if the cancel butt
     {
       "components": [
         {
-          "custom_id": "dontDeleteMessages",
+          "custom_id": "keepMessages",
           "emoji": undefined,
           "label": "Don't delete messages",
           "style": 4,
@@ -238,7 +238,7 @@ exports[`Banning spammer in other channels Cancels the action if the cancel butt
   ],
   "content": "Would you like to delete messages from the user being banned?",
   "ephemeral": true,
-  "withReponse": true,
+  "withResponse": true,
 }
 `;
 
@@ -248,7 +248,7 @@ exports[`Banning spammer in other channels Cancels the action if the response ti
     {
       "components": [
         {
-          "custom_id": "dontDeleteMessages",
+          "custom_id": "keepMessages",
           "emoji": undefined,
           "label": "Don't delete messages",
           "style": 4,
@@ -274,7 +274,7 @@ exports[`Banning spammer in other channels Cancels the action if the response ti
   ],
   "content": "Would you like to delete messages from the user being banned?",
   "ephemeral": true,
-  "withReponse": true,
+  "withResponse": true,
 }
 `;
 

services/spam-ban/spam-banning.service.js

@@ -81,8 +81,8 @@ class SpamBanningService {
   }
 
   static async #AskForDeleteMessages(interaction) {
-    const dontDeleteMessages = new ButtonBuilder()
-      .setCustomId('dontDeleteMessages')
+    const keepMessages = new ButtonBuilder()
+      .setCustomId('keepMessages')
       .setLabel("Don't delete messages")
       .setStyle(ButtonStyle.Danger);
 
@@ -97,7 +97,7 @@ class SpamBanningService {
       .setStyle(ButtonStyle.Secondary);
 
     const row = new ActionRowBuilder().addComponents(
-      dontDeleteMessages,
+      keepMessages,
       deleteMessages,
       cancel,
     );
@@ -106,19 +106,14 @@ class SpamBanningService {
       content: 'Would you like to delete messages from the user being banned?',
       components: [row],
       ephemeral: true,
-      withReponse: true,
+      withResponse: true,
     });
 
     try {
       const option = await response.awaitMessageComponent({ time: 60_000 });
 
-      if (option.customId === 'deleteMessages') {
-        return { result: 'deleteMessages' };
-      }
-      if (option.customId === 'dontDeleteMessages') {
-        return { result: 'dontDeleteMessages' };
-      }
-      return { result: 'cancel' };
+      return { result: option.customId };
+
     } catch {
       return { result: 'timeout' };
     }

services/spam-ban/spam-banning.service.test.js

@@ -161,15 +161,15 @@ describe('Banning spammer in other channels', () => {
   });
 
   it('Bans user and does not delete their messages if keep message button clicked', async () => {
-    interactionMock.setMessageComponentReturn('dontDeleteMessages');
+    interactionMock.setMessageComponentReturn('keepMessages');
     await SpamBanningService.handleInteraction(interactionMock);
     expect(interactionMock.guild.members.ban).toHaveBeenCalledTimes(1);
     expect(interactionMock.getBanArg()).toMatchSnapshot();
     expect(interactionMock.getReplyArg()).toMatchSnapshot();
   });
 
   it('Still deletes the message that triggered the interaction', async () => {
-    interactionMock.setMessageComponentReturn('dontDeleteMessages');
+    interactionMock.setMessageComponentReturn('keepMessages');
     await SpamBanningService.handleInteraction(interactionMock);
     expect(interactionMock.message.delete).toHaveBeenCalledTimes(1);
   });