Skip to content

Conversation

@Asartea
Copy link
Contributor

@Asartea Asartea commented Mar 10, 2025

Because

#647

This PR

  • Modifies the spam banning service to use guild.members.ban() for banning, which also allows banning user's who have left the server
  • Modifies the rest of the code to account for this
  • Slightly refactors some of the banning code
  • Updates tests and snapshots

Issue

Closes #647

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

Copy link
Contributor

@JustWaveThings JustWaveThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I pulled it down and ran it in my own server and tested it there as well. Thanks Asartea!

@JustWaveThings JustWaveThings merged commit e4eda0f into TheOdinProject:main Mar 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ban spammer command to handle people that left

2 participants