-
Notifications
You must be signed in to change notification settings - Fork 137
Improve discoverability and user guidance for Optimization Detective extensions #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Improve discoverability and user guidance for Optimization Detective extensions #2261
Conversation
…and Image Prioritizer Co-authored-by: Shyamsundar Gadde <[email protected]>
Co-authored-by: Shyamsundar Gadde <[email protected]>
| $installed_extensions = array_intersect( $extensions, array_keys( $installed_plugins ) ); | ||
|
|
||
| return $installed_extensions; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about if someone installs Optimization Detective and there are no other installed plugins that have a
Requires Pluginsheader that listsoptimization-detective, that we show an admin notice with the information at the top of the plugins list table after first activating the plugin?
Working on using Requires Plugins instead of hardcoded list.
| 'description' => __( 'Optimizes the performance of embeds through lazy-loading, preconnecting, and reserving space to reduce layout shifts.', 'optimization-detective' ), | ||
| 'url' => admin_url( 'plugin-install.php?tab=plugin-information&plugin=embed-optimizer&TB_iframe=true&width=772' ), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this info be fetched from the WordPress Plugin Directory using the newly introduced tag, or is it better to keep it hardcoded and only recommend Performance Lab plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @westonruter
| License: GPLv2 or later | ||
| License URI: https://www.gnu.org/licenses/gpl-2.0.html | ||
| Tags: performance, embeds | ||
| Tags: performance, embeds, optimization-detective |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a separate PR?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2261 +/- ##
==========================================
- Coverage 68.86% 68.38% -0.49%
==========================================
Files 90 90
Lines 7610 7665 +55
==========================================
+ Hits 5241 5242 +1
- Misses 2369 2423 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Fixes #2238
Relevant technical choices
optimization-detectiveto Image Prioritizer and Embed Optimizerreadme.txt