Skip to content

Conversation

@b1ink0
Copy link
Contributor

@b1ink0 b1ink0 commented Nov 11, 2025

Summary

Fixes #2238

Relevant technical choices

  • Adds tag optimization-detective to Image Prioritizer and Embed Optimizer readme.txt
  • Adds plugin action link directing users to plugin directory to discover extensions that provide optimization functionality using the Optimization Detective plugin.
  • Adds admin notice when Optimization Detective has no installed extensions
Screenshot 2025-11-11 at 10 45 14 PM

$installed_extensions = array_intersect( $extensions, array_keys( $installed_plugins ) );

return $installed_extensions;
}
Copy link
Contributor Author

@b1ink0 b1ink0 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about if someone installs Optimization Detective and there are no other installed plugins that have a Requires Plugins header that lists optimization-detective, that we show an admin notice with the information at the top of the plugins list table after first activating the plugin?

Working on using Requires Plugins instead of hardcoded list.

'description' => __( 'Optimizes the performance of embeds through lazy-loading, preconnecting, and reserving space to reduce layout shifts.', 'optimization-detective' ),
'url' => admin_url( 'plugin-install.php?tab=plugin-information&plugin=embed-optimizer&TB_iframe=true&width=772' ),
),
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this info be fetched from the WordPress Plugin Directory using the newly introduced tag, or is it better to keep it hardcoded and only recommend Performance Lab plugins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b1ink0 b1ink0 added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Nov 11, 2025
License: GPLv2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Tags: performance, embeds
Tags: performance, embeds, optimization-detective
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a separate PR?

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 1.81818% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.38%. Comparing base (7938a41) to head (773eb78).
⚠️ Report is 2 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/optimization-detective/helper.php 0.00% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #2261      +/-   ##
==========================================
- Coverage   68.86%   68.38%   -0.49%     
==========================================
  Files          90       90              
  Lines        7610     7665      +55     
==========================================
+ Hits         5241     5242       +1     
- Misses       2369     2423      +54     
Flag Coverage Δ
multisite 68.38% <1.81%> (-0.49%) ⬇️
single 35.23% <1.81%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it clear that Optimization Detective installed by itself does nothing and provide next steps

1 participant