Skip to content

Conversation

@ishandhanani
Copy link
Contributor

@ishandhanani ishandhanani commented Nov 10, 2025

SA submission version

Summary by CodeRabbit

  • Chores
    • Updated SGLang framework to version 0.5.4.post3 with kernel version 0.3.16.post5.
    • Removed FlashMLA build support.

@ishandhanani ishandhanani requested review from a team as code owners November 10, 2025 23:40
@github-actions github-actions bot added the feat label Nov 10, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

The pull request updates SGLang-related versions and removes FlashMLA build dependencies. The Dockerfile.sglang removes the FlashMLA build block and FLASHMLA_COMMIT argument while bumping SGL_KERNEL_VERSION and SGLANG_COMMIT. The pyproject.toml syncs the sglang dependency version accordingly.

Changes

Cohort / File(s) Summary
SGLang Version Updates & FlashMLA Removal
container/Dockerfile.sglang, pyproject.toml
Removed FlashMLA build block and FLASHMLA_COMMIT argument. Updated SGL_KERNEL_VERSION from 0.3.15 to 0.3.16.post5 and SGLANG_COMMIT from 0.5.3.post2 to 0.5.4.post3 in Dockerfile. Updated sglang optional dependency from 0.5.3.post2 to 0.5.4.post3 in pyproject.toml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

  • Verify FlashMLA is no longer required by any dependent code or functionality
  • Confirm SGLang version compatibility (0.5.4.post3) with existing codebase and kernel changes

Poem

🐰 With twitching nose and hoppy cheer,
FlashMLA bids farewell this year,
SGLang blooms in versions new,
Dependencies fresh—our work is true!

Pre-merge checks

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims an update to 0.5.3.post4, but the actual changes show updates to 0.5.4.post3, creating a discrepancy between the stated version and the implemented changes. Update the PR title to accurately reflect the actual version change: 'feat: sglang update to 0.5.4.post3' to match the changes in both Dockerfile.sglang and pyproject.toml.
Description check ⚠️ Warning The description 'SA submission version' is vague and provides no meaningful information about the changes, missing all required template sections like Overview, Details, reviewer guidance, and related issues. Complete the PR description using the template: add Overview explaining the SGLang update rationale, Details about version changes and FlashMLA removal, reviewer guidance on files to review, and any related GitHub issues.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b161896 and 3be1a2b.

📒 Files selected for processing (2)
  • container/Dockerfile.sglang (1 hunks)
  • pyproject.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: nv-anants
Repo: ai-dynamo/dynamo PR: 3290
File: docs/_includes/quick_start_local.rst:13-14
Timestamp: 2025-09-29T19:11:14.161Z
Learning: ai-dynamo package requires --prerelease=allow flag for installation due to sglang dependency requiring RC versions (e.g., sglang[all]==0.5.0rc2).
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: sglang (amd64)
  • GitHub Check: trtllm (arm64)
  • GitHub Check: trtllm (amd64)
  • GitHub Check: vllm (arm64)
  • GitHub Check: operator (amd64)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (3)
container/Dockerfile.sglang (2)

49-50: Verify PR title accuracy: stated "0.5.3.post4" but code uses "0.5.4.post3".

The PR title references sglang version 0.5.3.post4, but the Dockerfile specifies SGLANG_COMMIT=0.5.4.post3 (line 50) and SGL_KERNEL_VERSION 0.3.16.post5 (line 49). Confirm that the version numbers in the PR title and code are intentional and aligned.


42-213: Verify FlashMLA removal does not cause regressions.

The FlashMLA build dependencies and FLASHMLA_COMMIT argument have been removed. Confirm that:

  1. No downstream components or runtime stages depend on FlashMLA
  2. The SGLang build (lines 200-212) functions correctly without FlashMLA
  3. No other Dockerfile stages or related build scripts reference the removed argument
pyproject.toml (1)

61-65: Verify installation requirements with post-release versioning.

Line 64 updates the sglang dependency from 0.5.3.post2 to 0.5.4.post3. The retrieved learning from PR 3290 noted that previous sglang versions using RC tags (e.g., 0.5.0rc2) required the --prerelease=allow flag for pip installation.

Since 0.5.4.post3 is a post-release (not an RC), verify:

  1. The --prerelease=allow flag is no longer required in installation instructions
  2. Any documentation (e.g., docs/_includes/quick_start_local.rst referenced in learnings) should be updated if installation flags change

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishandhanani ishandhanani enabled auto-merge (squash) November 11, 2025 07:29
@ishandhanani ishandhanani merged commit d9b674b into main Nov 11, 2025
25 of 28 checks passed
@ishandhanani ishandhanani deleted the ishan/upd-sgl branch November 11, 2025 08:16
@Swipe4057
Copy link

sglang actual 0.5.5.post1
https://pypi.org/project/sglang/0.5.5.post1/

ishandhanani added a commit that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants