Feature/122 update eps #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPS: Update URF and EPS tank implementation questions to be required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates monitoring form configurations for EPS (water treatment system) construction and water quality testing. The changes improve form usability by restructuring tank implementation questions and adjusting field requirements.
- Reorganizes tank implementation sections from checklist format to individual detailed questions
- Updates field ordering across multiple water quality parameters
- Changes several optional fields to required fields
- Consolidates JSON formatting for dependency arrays
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| 2_1749632545233.monitoring.prod.json | Reorders water quality testing questions, updates E-coli label, and reformats dependency arrays for consistency |
| 2_1749624452908.monitoring.prod.json | Expands URF/EPS/Balance/Storage tank sections from multi-select checklists to granular option-based questions, updates field requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update backend/source/forms/2_1749632545233.monitoring.prod.json Co-authored-by: Copilot <[email protected]> Update backend/source/forms/2_1749632545233.monitoring.prod.json Co-authored-by: Copilot <[email protected]>
…into feature/122-update-eps
ifirmawan
force-pushed
the
feature/122-update-eps
branch
from
fa1ce84 to
2079418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO/DONE