Skip to content

Conversation

@tabrisnet
Copy link
Collaborator

Description

More or less what it says on the tin, and more specifically what is mentioned in the series.conf

patch series derived from:
git format-patch -o ~/build/armbian-build/patch/kernel/archive/filogic-6.16/patches.armbian/ v6.16.12..6.16.12-rsslro
where 6.16.12-rsslro was from taking https://github.com/frank-w/BPI-Router-Linux branch:6.16-rsslro
then git rebase v6.16.12 where this tag was from https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git tag:v6.16.12
two patches are then skipped for being empty, 0001 & 0017

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Nov 1, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2025

Walkthrough

The change edits config/sources/families/filogic.conf in the edge branch: explicit KERNELSOURCE and KERNELBRANCH assignments are commented out. KERNEL_MAJOR_MINOR is fixed to 6.16 and KERNELPATCHDIR and LINUXCONFIG are computed from that value and the branch name, so the edge configuration no longer declares kernel source/branch directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file, small syntactic change (commenting out assignments and adjusting derived variables)
  • Review should verify downstream logic that computes/uses KERNELPATCHDIR and LINUXCONFIG handles the absence of explicit KERNELSOURCE/KERNELBRANCH
  • Check consistency with other family configs and CI/build jobs that may expect explicit kernel source/branch values

Possibly related PRs

Suggested reviewers

  • rpardini
  • chraac
  • krachlatte
  • EvilOlaf
  • igorpecovnik
  • chainsx

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "change from frank-w's tree to just a git-format-patches from his tree" directly and clearly describes the main change in the changeset. The raw summary confirms this is the primary modification: KERNELSOURCE and KERNELBRANCH assignments are removed and replaced with commented-out lines, with the configuration now relying on KERNEL_MAJOR_MINOR and derived values instead of explicit source/branch details. The title is specific, concise, and accurately represents the transition from direct tree usage to git-format-patches generation that the changeset implements.
Description Check ✅ Passed The pull request description is directly related to the changeset and provides substantial, meaningful details about the change. It explains the specific git command used to generate the patches, identifies the source branch (frank-w/BPI-Router-Linux branch 6.16-rsslro), specifies the kernel tag used for rebasing (v6.16.12), notes which patches were skipped and why (0001 and 0017 were empty), and provides context by referencing PR #8772. The description clearly conveys the rationale for replacing direct tree usage with a git-format-patches approach, making it well-suited to understanding the PR's purpose.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2a22df8 and ba318e8.

⛔ Files ignored due to path filters (88)
  • patch/kernel/archive/filogic-6.16/patches.armbian/0001-6.16.12.diff is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0001-v6-coverletter-net-next-rework-IRQ-handling-in-mtk_e.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0002-net-ethernet-mtk_eth_soc-support-named-IRQs.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0003-net-ethernet-mtk_eth_soc-add-consts-for-irq-index.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0004-net-ethernet-mtk_eth_soc-skip-first-IRQ-if-not-used.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0005-net-ethernet-mtk_eth_soc-only-use-legacy-mode-on-mis.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0006-build.sh-add-build-script-config-defconfig-and-fit-s.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0007-build.sh-add-additional-build-script-config-defconfi.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0008-defconfig-r3-fix-warning-about-BASE_SMALL.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0009-build.conf-change-upload-target.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0010-arm-dts-mt7623-swap-mmc-and-put-uart2-first.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0011-arm64-dts-disable-dtbs-for-dtbs_check.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0012-dt-bindings-interconnect-add-mt7988-cci-compatible.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0013-arm64-dts-mediatek-mt7988-add-cci-node.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0014-arm64-dts-mediatek-mt7988a-bpi-r4-add-proc-supply-fo.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0015-arm64-dts-mediatek-mt7988a-bpi-r4-drop-unused-pins.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0016-arm64-dts-mediatek-mt7988a-bpi-r4-add-gpio-leds.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0017-v9-coverletter-further-mt7988-devicetree-work.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0018-dt-bindings-net-mediatek-net-update-mac-subnode-patt.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0019-dt-bindings-net-mediatek-net-allow-up-to-8-IRQs.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0020-dt-bindings-net-mediatek-net-allow-irq-names.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0021-dt-bindings-net-mediatek-net-add-sram-property.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0022-dt-bindings-net-dsa-mediatek-mt7530-add-dsa-port-def.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0023-dt-bindings-net-dsa-mediatek-mt7530-add-internal-mdi.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0024-arm64-dts-mediatek-mt7986-add-sram-node.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0025-arm64-dts-mediatek-mt7986-add-interrupts-for-RSS-and.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0026-arm64-dts-mediatek-mt7988-add-basic-ethernet-nodes.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0027-arm64-dts-mediatek-mt7988-add-switch-node.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0028-arm64-dts-mediatek-mt7988a-bpi-r4-add-aliases-for-et.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0029-arm64-dts-mediatek-mt7988a-bpi-r4-add-sfp-cages-and-.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0030-arm64-dts-mediatek-mt7988a-bpi-r4-configure-switch-p.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0031-arm64-dts-mediatek-mt7988a-bpi-r4-drop-readonly-from.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0032-dt-bindings-net-pcs-mediatek-sgmiisys-add-phys-and-r.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0033-dt-binding-sgmiisys-re-add-pcs-cells.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0034-dts-re-add-sgmiisys.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0035-arm64-dts-mt7988-add-cpufreq-calibration-efuse-subno.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0036-net-ethernet-mtk_eth_soc-move-desc-assignment-below-.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0037-dts-enable-mt818-36-for-cci-testing.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0038-Revert-dts-enable-mt818-36-for-cci-testing.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0039-enable-bpi-r3-DTBs-for-testing.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0040-only-enable-mediatek-for-arm-to-increase-dtbs_check.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0041-enable-some-arm64-dts-to-check-binding.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0042-defconfig-r4-add-sram-driver.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0043-net-ethernet-mtk_eth_soc-improve-support-for-named-i.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0044-net-ethernet-mtk_eth_soc-fix-kernel-doc-comment.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0045-net-ethernet-mtk_eth_soc-use-generic-allocator-for-S.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0046-defconfig-r3-add-sram.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0047-WIP-dts64-r4-add-ubi-partition-to-spin-nand.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0048-add-mtd-rw-driver.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0049-arm64-dts-add-usxgmii-pcs-and-link-both-pcs.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0050-arm64-dts-update-bpi-r4.dtsi-to-actual-state.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0051-net-ethernet-mtk_eth_soc-add-paths-and-SerDes-modes-.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0052-net-phylink-keep-and-use-MAC-supported_interfaces-in.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0053-net-phy-introduce-phy_interface_copy-helper.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0054-net-phylink-introduce-internal-phylink-PCS-handling.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0055-net-phylink-add-phylink_release_pcs-to-externally-re.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0056-net-pcs-implement-Firmware-node-support-for-PCS-driv.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0057-net-phylink-support-late-PCS-provider-attach.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0058-dt-bindings-net-ethernet-controller-permit-to-define.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0059-net-pcs-airoha-add-PCS-driver-for-Airoha-SoC.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0060-dt-bindings-net-pcs-Document-support-for-Airoha-Ethe.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0061-net-pcs-pcs-mtk-lynxi-add-platform-driver-for-MT7988.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0062-dt-bindings-net-pcs-add-bindings-for-MediaTek-USXGMI.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0063-net-pcs-add-driver-for-MediaTek-USXGMII-PCS.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0064-net-ethernet-mtk_eth_soc-add-more-DMA-monitor-for-MT.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0065-hwrng-add-driver-for-MediaTek-TRNG-SMC.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0066-dts64-enable-sata-and-disable-pcie-slot-CN8-shared.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0067-arm64-dts-mt7622-fix-sata.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0068-kdeb-try-to-add-kernels-for-bpi-boards-to-deb-packag.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0069-kdeb-fix-deb-build-for-R3-R4.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0070-build.conf-change-to-r4.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0071-defconfig-r4-disable-STRICT_DEVMEM-to-allow-register.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0072-net-ethernet-mtk_eth_soc-add-register-definitions-fo.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0073-net-ethernet-mtk_eth_soc-add-rss-support.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0074-net-mediatek-mtk_eth_soc-drop-RSS-capabilty-for-mt79.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0075-net-mtk_eth_soc-fix-mtk_-get-set-_rxfh-callback-head.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0076-net-ethernet-mtk_eth_soc-Add-LRO-support.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0077-readme-add-README.md-for-RSS-LRO.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0078-net-ethernet-mtk_eth_soc-support-forced-reset-contro.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0079-net-mediatek-add-proprietary-debugfs.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0080-enable-debugfs.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0081-net-mediatek-mtk_eth_soc-add-RSS-capabilty-for-mt798.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0082-net-mediatek-mtk_eth_soc-enable-lro-stats-from-debug.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0083-net-mediatek-change-mt7986-from-RSS-to-LRO-only-1-po.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/patches.armbian/0084-net-mediatek-mtk_eth_soc-check-if-irqs-were-loaded-t.patch is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/series.armbian is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/series.armbian is excluded by !patch/**
  • patch/kernel/archive/filogic-6.16/series.conf is excluded by !patch/**
📒 Files selected for processing (1)
  • config/sources/families/filogic.conf (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/sources/families/filogic.conf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tabrisnet tabrisnet force-pushed the tabrisnet_filogic_edge_6.16-patches branch from 2a22df8 to ba318e8 Compare November 1, 2025 16:05
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Nov 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Nov 2, 2025
@igorpecovnik igorpecovnik merged commit 3fcb8ef into armbian:main Nov 2, 2025
10 checks passed
@tabrisnet tabrisnet deleted the tabrisnet_filogic_edge_6.16-patches branch November 3, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

2 participants