Skip to content

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Nov 9, 2025

Description

First login text for automated builds changed to:

image

How Has This Been Tested?

  • Manual execution

Checklist:

  • My code follows the style guidelines of this project

Summary by CodeRabbit

  • Updates
    • Simplified the initial login/welcome message to a concise "Developer Preview Build" notice, clarifying the build is for development/testing, may contain unfinished or unstable features, and advising caution for production use.

@igorpecovnik igorpecovnik requested a review from a team as a code owner November 9, 2025 18:32
@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review BSP Board Support Packages labels Nov 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Walkthrough

Replaced multi-line automated-build warnings in the armbian-firstlogin script with a concise "Developer Preview Build" message in two echo blocks; no control flow, logic, or exported/public declarations were changed.

Changes

Cohort / File(s) Change Summary
Message Updates
packages/bsp/common/usr/lib/armbian/armbian-firstlogin
Replaced the previous multi-line automated-build warning with a shorter "Developer Preview Build" notice in two locations (symmetric echo blocks for interactive/nightly and non-nightly paths).

Sequence Diagram(s)

(omitted — change is only user-visible message text, no control-flow modifications)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change limited to user-facing strings
  • No logic, control-flow, or API/interface changes
  • Review attention: confirm both echo locations updated and wording is consistent

Suggested reviewers

  • rpardini
  • hzyitc
  • PanderMusubi

Poem

🐰 A short note hops onto the screen,
Developer preview — tidy and clean.
No jumps in logic, just gentler tone,
A rabbit’s small cheer for changes unknown. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Improve first login for automated builds' directly relates to the main change: updating the first-login warning message displayed during automated builds, replacing the multi-line warning with a shorter Developer Preview Build message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch welcome_screen

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1128176 and d86b140.

📒 Files selected for processing (1)
  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/bsp/common/usr/lib/armbian/armbian-firstlogin (1)

807-811: Consider using ASCII hyphen for better terminal compatibility.

The updated warning message is clear and appropriately communicates the developer preview status. However, Line 811 contains an em dash (—) which is a UTF-8 multi-byte character that may not render correctly in all terminal environments, potentially appearing as garbled characters. For maximum portability, consider using an ASCII hyphen or double-hyphen instead.

Apply this diff to improve compatibility:

-		echo -e "Expect things to change — or even break — as improvements are made."
+		echo -e "Expect things to change - or even break - as improvements are made."
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd81c9 and 1128176.

📒 Files selected for processing (1)
  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin (1 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.
Learnt from: EvilOlaf
Repo: armbian/build PR: 8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.
Learnt from: SuperKali
Repo: armbian/build PR: 8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:16:10.236Z
Learning: In Armbian board configuration files, WIP (Work In Progress) comments describe intended goals or planned features rather than current implementation state. For example, a comment like "WIP: current kernel" indicates that current kernel support is being worked toward, even if KERNEL_TARGET doesn't yet include "current".
Learnt from: Grippy98
Repo: armbian/build PR: 8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
📚 Learning: 2025-07-21T04:12:02.439Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.

Applied to files:

  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin
📚 Learning: 2025-07-17T04:12:33.125Z
Learnt from: pyavitz
Repo: armbian/build PR: 8388
File: config/boards/kickpik2b.conf:1-14
Timestamp: 2025-07-17T04:12:33.125Z
Learning: In the Armbian build system, board configuration files (*.conf) follow a project standard of not including shebang lines, even though they contain bash code and are sourced by the build system. This is an established Armbian convention that individual contributors are expected to follow, and changes to this standard would require broader project maintainer approval.

Applied to files:

  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin
📚 Learning: 2025-09-27T21:50:15.915Z
Learnt from: tabrisnet
Repo: armbian/build PR: 8678
File: config/kernel/linux-sunxi64-current.config:94-94
Timestamp: 2025-09-27T21:50:15.915Z
Learning: When kernel config files are generated through Armbian's automated process (previous config → armbian-kernel.sh changes → make oldconfig → Armbian machinery processing), manual config file edits are not appropriate since they would be overwritten. Deprecated option handling should be implemented in the automated tooling instead.

Applied to files:

  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin
📚 Learning: 2025-09-25T18:37:00.330Z
Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Applied to files:

  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin
📚 Learning: 2025-06-24T10:08:40.313Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.

Applied to files:

  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin
📚 Learning: 2025-07-23T10:01:41.310Z
Learnt from: amazingfate
Repo: armbian/build PR: 8419
File: lib/functions/host/prepare-host.sh:272-275
Timestamp: 2025-07-23T10:01:41.310Z
Learning: In the Armbian build system, the design philosophy is to fail fast when host dependencies are not met rather than gracefully skipping unsupported architectures. This ensures build environment consistency and prevents silent failures. Host dependency checks should be explicit and non-negotiable.

Applied to files:

  • packages/bsp/common/usr/lib/armbian/armbian-firstlogin

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 10, 2025
@igorpecovnik igorpecovnik merged commit 66453c6 into main Nov 10, 2025
11 checks passed
@igorpecovnik igorpecovnik deleted the welcome_screen branch November 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants