Skip to content

Conversation

@sogladev
Copy link
Member

@sogladev sogladev commented Nov 11, 2025

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

quest_offer_reward_locale does not need to be updated for entry 11564

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@TheSCREWEDSoftware
Copy link
Contributor

I know sometimes the text of certain quest don't match fully or have typo, it this be one of the cases or actualy wrong info in AC?

@github-actions github-actions bot added the DB related to the SQL database label Nov 11, 2025
@sogladev
Copy link
Member Author

I know sometimes the text of certain quest don't match fully or have typo, it this be one of the cases or actualy wrong info in AC?

likely text taken from the beta and was never updated. See original MoP https://youtu.be/1SrzsIdfmds?si=hmnsMY_RMFM8BU5m&t=150, also locales don't mention it. I can't find an earlier source

@Nyeriah Nyeriah merged commit 5104463 into azerothcore:master Nov 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Succulent Orca Stew is still using the old quest completion text

3 participants