Skip to content

Commit 7e2b63f

Browse files
authored
fix: variable naming to be consistent (#759)
Update the assume role policies variable name to include the `lambda_` prefix so it is consistent with the other lambda variable names.
1 parent 8203a31 commit 7e2b63f

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

lambda_schedule/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ No requirements.
3535

3636
| Name | Description | Type | Default | Required |
3737
|------|-------------|------|---------|:--------:|
38-
| <a name="input_assume_role_policies"></a> [assume\_role\_policies](#input\_assume\_role\_policies) | (Optional, default empty list) List of additional IAM policy documents to add to the Lambda's assume role policy. These are combined with the default Lambda service principal policy. | `list(string)` | `[]` | no |
3938
| <a name="input_billing_tag_key"></a> [billing\_tag\_key](#input\_billing\_tag\_key) | (Optional, default 'CostCentre') The name of the billing tag | `string` | `"CostCentre"` | no |
4039
| <a name="input_billing_tag_value"></a> [billing\_tag\_value](#input\_billing\_tag\_value) | (Required) The value of the billing tag | `string` | n/a | yes |
4140
| <a name="input_create_ecr_repository"></a> [create\_ecr\_repository](#input\_create\_ecr\_repository) | (Optional, default true) Whether to create an ECR repository for the Lambda image | `bool` | `true` | no |
4241
| <a name="input_lambda_architectures"></a> [lambda\_architectures](#input\_lambda\_architectures) | (Optional, default ['x86\_64']) The architectures of the Lambda function | `list(string)` | <pre>[<br/> "x86_64"<br/>]</pre> | no |
42+
| <a name="input_lambda_assume_role_policies"></a> [lambda\_assume\_role\_policies](#input\_lambda\_assume\_role\_policies) | (Optional, default empty list) List of additional IAM policy documents to add to the Lambda's assume role policy. These are combined with the default Lambda service principal policy. | `list(string)` | `[]` | no |
4343
| <a name="input_lambda_ecr_arn"></a> [lambda\_ecr\_arn](#input\_lambda\_ecr\_arn) | (Optional, defaults to null) The ARN of the ECR repository containing the Lambda image | `string` | `null` | no |
4444
| <a name="input_lambda_environment_variables"></a> [lambda\_environment\_variables](#input\_lambda\_environment\_variables) | (Optional, defaults to empty map) Environment variables for the Lambda function | `map(string)` | `{}` | no |
4545
| <a name="input_lambda_image_tag"></a> [lambda\_image\_tag](#input\_lambda\_image\_tag) | (Optional, defaults to 'latest') The image tag to use for the Lambda function | `string` | `"latest"` | no |

lambda_schedule/input.tf

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ variable "lambda_architectures" {
2121
default = ["x86_64"]
2222
}
2323

24+
variable "lambda_assume_role_policies" {
25+
type = list(string)
26+
description = "(Optional, default empty list) List of additional IAM policy documents to add to the Lambda's assume role policy. These are combined with the default Lambda service principal policy."
27+
default = []
28+
}
29+
2430
variable "lambda_ecr_arn" {
2531
description = "(Optional, defaults to null) The ARN of the ECR repository containing the Lambda image"
2632
type = string
@@ -110,9 +116,3 @@ variable "s3_arn_write_path" {
110116
error_message = "The S3 ARN must be in the format 'arn:aws:s3:::bucket-name/path/*'"
111117
}
112118
}
113-
114-
variable "assume_role_policies" {
115-
type = list(string)
116-
description = "(Optional, default empty list) List of additional IAM policy documents to add to the Lambda's assume role policy. These are combined with the default Lambda service principal policy."
117-
default = []
118-
}

lambda_schedule/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ module "this_lambda" {
1919
environment_variables = var.lambda_environment_variables
2020
vpc = var.lambda_vpc_config
2121
policies = local.policies
22-
assume_role_policies = var.assume_role_policies
22+
assume_role_policies = var.lambda_assume_role_policies
2323

2424
billing_tag_key = var.billing_tag_key
2525
billing_tag_value = var.billing_tag_value

0 commit comments

Comments
 (0)