feat(gha): add upgrade steps test

Author: bsuttor

.github/workflows/test.yml

@@ -92,3 +92,8 @@ jobs:
         bin/instance run test_scripts/admin_password_not_updated.py
       env:
         ADMIN_PASSWORD: test1234
+    - name: Run all upgrade steps
+      run: |
+        bin/instance run test_scripts/upgrade_steps.py
+      env:
+        ACTIVE_BIGBANG_EXPANSION: "True"

src/collective/big/bang/configure.zcml

@@ -17,7 +17,6 @@
       handler=".big.bang"
       />
 
-  <!--for="zope.processlifetime.IDatabaseOpenedWithRoot"-->
   <subscriber
       for="zope.processlifetime.IDatabaseOpenedWithRoot"
       handler=".expansion.started"

src/collective/big/bang/expansion.py

@@ -62,7 +62,7 @@ def upgrade_one_profile(setup, profile_id):
         do_upgrades(setup, profile_id, upgrades)
         upgrades = list_upgrades(setup, profile_id)
     else:
-        logger.info("Finished upgrading {1} profile".format(profile_id))
+        logger.info("Finished upgrading {0} profile".format(profile_id))
 
 
 def list_upgrades(setup, profile_id):

test_scripts/upgrade_steps.py

@@ -7,6 +7,8 @@
 
 def main(app):
     site_id = os.getenv("SITE_ID", "Plone")
+    if site_id in app.objectIds():
+        del app[site_id]
     create_plone_site(app, site_id)
     assert site_id in app.objectIds(), "Plone site not existing"
     plone = app.get(site_id)