[Feature request] Scroll to top in the stream list

[burikoni]

The 'Popular' tab does not show the button to scroll to the top of the list when scrolling.

Xtra/app/src/main/java/com/github/andreyasadchy/xtra/ui/game/streams/GameStreamsFragment.kt

Line 48 in eccfd1b

private var _binding: CommonRecyclerViewLayoutBinding? = null

GameStreamsFragment uses a generic binding (CommonRecyclerViewLayoutBinding), unlike GamesFragment, which does have the 'scroll to top' button.

Xtra/app/src/main/java/com/github/andreyasadchy/xtra/ui/games/GamesFragment.kt

Line 50 in eccfd1b

private var _binding: FragmentGamesBinding? = null

I am wondering if there is a technical reason for why it is implemented that way, or if it simply needs to be migrated to a dedicated binding.

Thank you.

[crackededed]

you can tap on the popular tab again to scroll up.

Xtra/app/src/main/java/com/github/andreyasadchy/xtra/ui/main/MainActivity.kt

Lines 793 to 800 in eccfd1b

	setOnItemReselectedListener {
	if (!navController.popBackStack(it.itemId, false)) {
	val currentFragment = supportFragmentManager.findFragmentById(R.id.navHostFragment)?.childFragmentManager?.fragments?.getOrNull(0)
	if (currentFragment is Scrollable) {
	currentFragment.scrollToTop()
	}
	}
	}

this is not obvious at all though so the scroll button should probably be added here as well or something

[burikoni]

this is not obvious at all though so the scroll button should probably be added here as well or something

Yes, intuitively, upon pressing the tab again, one would think it would reload to its initial state. This remains pending for future implementations.

[burikoni]

Xtra/app/src/main/java/com/github/andreyasadchy/xtra/ui/top/TopStreamsFragment.kt

Lines 192 to 199 in eccfd1b

	val enableScrollTopButton = !args.tags.isNullOrEmpty()
	initializeAdapter(binding.recyclerViewLayout, pagingAdapter, enableScrollTopButton = enableScrollTopButton)
	if (enableScrollTopButton && requireContext().prefs().getBoolean(C.UI_SCROLLTOP, true)) {
	binding.recyclerViewLayout.scrollTop.setOnClickListener {
	scrollToTop()
	it.gone()
	}
	}

Why is the scrollTop conditioned on whether there are tags or not?
Wouldn't it make more sense if it only depended on the UI_SCROLLTOP?

I meant to refer to this fragment TopStreamsFragment (which loads in the "Popular" tab): the button to go to the top does not always appear.

[crackededed]

when args.tags is empty, pressing the popular tab can be used to scroll up. when navigating to TopStreamsFragment from another fragment by tapping on a stream tag, args.tags is not empty and pressing on the popular tab will go back to the default TopStreamsFragment. so the scroll up button needs to show there.

[burikoni]

when args.tags is empty, pressing the popular tab can be used to scroll up. when navigating to TopStreamsFragment from another fragment by tapping on a stream tag, args.tags is not empty and pressing on the popular tab will go back to the default TopStreamsFragment. so the scroll up button needs to show there.

Yes, I understand how it works, but I don’t understand why it is conditioned that way. It would make more sense for it to always be active, because, for example, if it is only filtered by language, the button does not appear.