Merge pull request #4174 from craftcms/nathaniel/com-495-5x-missing-db-indexes-after-upgrading-from-commerce-4

[5.x] Missing DB indexes for catalog pricing

Author: nfourtythree

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Fixed a SQL error that could occur when viewing unfulfilled orders on PostgreSQL. ([#4171](https://github.com/craftcms/commerce/issues/4171))
 - Fixed a bug where duplicate pricing catalog jobs were being queued. ([#4136](https://github.com/craftcms/commerce/issues/4136))
+- Fixed missing pricing catalog database indexes. ([#4160](https://github.com/craftcms/commerce/issues/4160))
 - Deprecated `craft\commerce\services\CatalogPricing::afterSavePurchasableHandler()`.
 
 ## 5.4.9 - 2025-10-29

src/Plugin.php

@@ -257,7 +257,7 @@ public static function editions(): array
     /**
      * @inheritDoc
      */
-    public string $schemaVersion = '5.4.0.6';
+    public string $schemaVersion = '5.4.0.7';
 
     /**
      * @inheritdoc

src/migrations/Install.php

@@ -1064,18 +1064,18 @@ public function dropProjectConfig(): void
     public function createIndexes(): void
     {
         $this->createIndex(null, Table::CATALOG_PRICING, 'catalogPricingRuleId', false);
+        $this->createIndex(null, Table::CATALOG_PRICING, 'isPromotionalPrice', false);
         $this->createIndex(null, Table::CATALOG_PRICING, 'purchasableId', false);
         $this->createIndex(null, Table::CATALOG_PRICING, 'storeId', false);
         $this->createIndex(null, Table::CATALOG_PRICING, 'userId', false);
-        $this->createIndex(null, Table::CATALOG_PRICING, ['purchasableId', 'storeId', 'isPromotionalPrice', 'price'], false);
         $this->createIndex(null, Table::CATALOG_PRICING, ['purchasableId', 'storeId', 'isPromotionalPrice', 'price', 'catalogPricingRuleId', 'dateFrom', 'dateTo'], false);
+        $this->createIndex(null, Table::CATALOG_PRICING, ['purchasableId', 'storeId', 'isPromotionalPrice', 'price'], false);
+        $this->createIndex(null, Table::CATALOG_PRICING, ['purchasableId', 'storeId'], false);
         $this->createIndex(null, Table::CATALOG_PRICING_RULES, 'storeId', false);
         $this->createIndex(null, Table::CATALOG_PRICING_RULES_USERS, 'catalogPricingRuleId', false);
         $this->createIndex(null, Table::CATALOG_PRICING_RULES_USERS, 'userId', false);
         $this->createIndex(null, Table::COUPONS, 'code', false);
         $this->createIndex(null, Table::COUPONS, 'discountId', false);
-        $this->createIndex(null, Table::CATALOG_PRICING, 'isPromotionalPrice', false);
-        $this->createIndex(null, Table::CATALOG_PRICING, ['purchasableId', 'storeId'], false);
         $this->createIndex(null, Table::CUSTOMERS, 'customerId', true);
         $this->createIndex(null, Table::CUSTOMERS, 'primaryBillingAddressId', false);
         $this->createIndex(null, Table::CUSTOMERS, 'primaryPaymentSourceId', false);

src/migrations/m251111_092942_ensure_catalog_pricing_indexes.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace craft\commerce\migrations;
+
+use craft\commerce\db\Table;
+use craft\db\Migration;
+
+/**
+ * m251111_092942_ensure_catalog_pricing_indexes migration.
+ */
+class m251111_092942_ensure_catalog_pricing_indexes extends Migration
+{
+    /**
+     * @inheritdoc
+     */
+    public function safeUp(): bool
+    {
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, 'catalogPricingRuleId', false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, 'isPromotionalPrice', false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, 'purchasableId', false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, 'storeId', false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, 'userId', false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, ['purchasableId', 'storeId', 'isPromotionalPrice', 'price', 'catalogPricingRuleId', 'dateFrom', 'dateTo'], false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, ['purchasableId', 'storeId', 'isPromotionalPrice', 'price'], false);
+        $this->createIndexIfMissing(Table::CATALOG_PRICING, ['purchasableId', 'storeId'], false);
+
+        return true;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function safeDown(): bool
+    {
+        echo "m251111_092942_ensure_catalog_pricing_indexes cannot be reverted.\n";
+        return false;
+    }
+}