-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: to_dict in OpenAIResponsesChatGenerator and json_schema for structured outputs #10043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Amnah199 please make sure to update and fix the |
|
@Amnah199 should we also add an integration test where we pass in a pydantic model, serialize the component, deserialize it and run the deserialized component to ensure it has the expected output? I'm asking since it feels a bit odd that at serialization time we convert a |
|
I tested this aspect locally but sure will add it to the tests. |
sjrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…et-ai/haystack into fix-ser-and-schema-support
Related Issues
to_dictmethod currently converts Pydantic models to JSON Schema, which can cause errors when the deserialized component is executed.textinstead oftext_format.Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.