refactor: adapt to FullChat.contacts removal

[Simon-Laux]

TODO

• we should figure out how to make async dialogs using suspense (with error handling/boundary) to ensure that the dialog does not resize/flicker when opened.
• use useRpcFetch where it makes sense -> especially for getting the first contact.
• changlog entry

depends on chatmail/core#7282

[WofWca]

The TODO doesn't sound like a blocker? The flicker only happens once when you open it, right?

[Simon-Laux]

The TODO doesn't sound like a blocker? The flicker only happens once when you open it, right?

technically no, but I personally think that it is a big enough UX regression to investigate solutions. (I'm super annoyed by the flickering)

[Simon-Laux]

seems like the flickering also breaks the e2e test

[WofWca]

seems like the flickering also breaks the e2e test

I'll take a look.

[WofWca]

This is not about flickering. It's because all members are shown as "Past members":

[WofWca]

I checked that the moved code hasn't changed.

[WofWca]

This could be undefined, which would result in an error. Behavior-wise it's OK, but it will spam the console:

deltachat-desktop/packages/frontend/src/hooks/useFetch.ts

Lines 141 to 153 in 1dbf369

	.catch(err => {
	if (!outdated) {
	setResultAndFetchId({
	result: { ok: false, err },
	fetchId,
	})
	log.errorWithoutStackTrace(
	'error while executing fetch',
	err,
	fetchId
	)
	}
	})

An "ideal" solution would be to pass null instead of [accountId, contactId]touseRpcFetch`.

[WofWca]

About the flicker: I'm not sure if "suspense" is really what we need. We know the number of contact beforehand, so why not just display placeholders in place of them? Or at least one div of height depending on the number of contacts..