refactor: adapt to jsonrpc api change: chat_type as string union #5530
Conversation
Simon-Laux
added
the
wait-for-core
Simon-Laux
force-pushed
the
simon/adapt-to-chattype-string-union
branch
from
5337e31 to
13b018e
Compare
There was a problem hiding this comment.
this extra typeof is because I changed how the constants are exported to fix some weird type issues
Simon-Laux
force-pushed
the
simon/adapt-to-chattype-string-union
branch
from
13b018e to
2ff9ffa
Compare
Simon-Laux
changed the title
Simon-Laux
force-pushed
the
simon/adapt-to-chattype-string-union
branch
from
dd055e4 to
4f57b8f
Compare
Simon-Laux
removed
the
wait-for-core
|
I have released core 2.26.0 with this breaking change, so this needs to be merged now. |
|
We will do the release 2.25.0 before and then merge it |
WofWca
force-pushed
the
simon/adapt-to-chattype-string-union
branch
from
4f57b8f to
1b39ec8
Compare
There was a problem hiding this comment.
I hope you don't mind that I rebased this. There was only one conflict which was easy to resolve.
I have checked all the places, and none seem to mix up the new types.
I have also checked that the old variable names are no longer in the code base.
This adds some type casts, but the situation is still better than what we had before.
This can be merged as soon as we upgrade core.
| // (but not e.g. in groups consisting of 2 members). | ||
| // https://github.com/chatmail/core/blob/738dc5ce197f589131479801db2fbd0fb0964599/src/calls.rs#L147 | ||
| chat.chatType === C.DC_CHAT_TYPE_SINGLE && | ||
| chat.chatType === "Single" && |
There was a problem hiding this comment.
| chat.chatType === "Single" && | |
| chat.chatType === 'Single' && |
This will fix all lint warnings.
depends on chatmail/core#7285 probably part of core 2.26
also depends on #5531