-
-
Notifications
You must be signed in to change notification settings - Fork 203
feat: add multitransport #5680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add multitransport #5680
Conversation
19177b6 to
572ba3c
Compare
572ba3c to
3590028
Compare
| 'configured_addr', | ||
| transport.addr | ||
| ) | ||
| await BackendRemote.rpc.stopIo(accountId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These manual stopIo and startIo calls should not be needed anymore, the core now does this when configured_addr is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pulled the latest state of the core multitransport PR. When I now add a new transport I see a lot of events in the logs and they don't stop any more:
121.6s [i]core/event: 2 src/imap.rs:778: 0 mails read from "INBOX".
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 1/1762373735 previous 3/1762373687.
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 3/1762373687 previous 1/1762373735.
121.6s [D]core/event: 2 ConnectivityChanged { kind: 'ConnectivityChanged' }
121.6s [D]core/event: 2 ImapInboxIdle { kind: 'ImapInboxIdle' }
121.6s [i]core/event: 2 src/scheduler.rs:685: IMAP session in folder "INBOX" supports IDLE, using it.
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 1/1762373735 previous 3/1762373687.
121.6s [i]core/event: 2 src/imap/idle.rs:39: Skipping IDLE in "INBOX" because there may be new mail.
121.6s [i]core/event: 2 src/scheduler.rs:425: IMAP loop iteration for inbox finished, keeping the session.
121.6s [i]core/event: 2 src/imap.rs:881: resync_folder_uids: Collected 0 message IDs in INBOX.
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 3/1762373687 previous 1/1762373735.
121.6s [i]core/event: 2 src/imap.rs:585: fetch_new_msg_batch(INBOX): UIDVALIDITY=1762373687, UIDNEXT=3.
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 1/1762373735 previous 3/1762373687.
121.6s [i]core/event: 2 src/imap.rs:778: 0 mails read from "INBOX".
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 3/1762373687 previous 1/1762373735.
121.6s [i]core/event: 2 src/imap.rs:881: resync_folder_uids: Collected 0 message IDs in INBOX.
121.6s [i]core/event: 2 src/imap/select_folder.rs:248: uid/validity change folder INBOX: new 1/1762373735 previous 3/1762373687.
121.6s [i]core/event: 2 src/imap.rs:585: fetch_new_msg_batch(INBOX): UIDVALIDITY=1762373735, UIDNEXT=1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is broken by the latest WIP commit chatmail/core@37a6304, the branch is not usable at the moment.
But once it is working stop_io and start_io will not be necessary.
resolves #5648
Needs local core from chatmail/core#7348
Be aware not to use with existings accounts see #5648 (comment)