-
-
Notifications
You must be signed in to change notification settings - Fork 203
fix: invert pinch zoom direction #5695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0229e7d to
7e1cf53
Compare
WofWca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might fix it for the pinch gesture on Mac, but this inverts it for the scroll wheel.
Yes I know, but that's what I experienced in my tests. Did you test it with your touchpad? On mine the behaviour was wrong on Linux too. But maybe since I had to use an external touchpad which behaved like a Mac?? |
|
No, I only tested with a mouse. |
|
@nicodh You seem to have edited my comment? Have you tried using the mouse scroll wheel? It's supposed to be "scroll up to zoom in, scroll down to zoom out", which it is not in this MR. |
Hmm, for me I have the opposite behaviour. What do you see in main branch when opening the full screen view (like in media gallery). There I see: scroll down => zoom in, scoll up => zoom out But most important: the scroll behaviour is th opposite of the behaviour in the Image Cropper. Can you confirm that? (in main branch) |
So for me even Ctr + mouse move has the same zoom direction as other applications (and other components in desktop) with this PR. Before it was just the opposition direction in the ImageCropper. But of course the PR title is wrong then and I will change it |
|
For me it's "scroll up to zoom in" in the fullscreen image view. Same is on the main branch for the image cropper. |
resolves #5641