Skip to content

Conversation

@nicodh
Copy link
Member

@nicodh nicodh commented Nov 9, 2025

resolves #5641

Copy link
Member

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might fix it for the pinch gesture on Mac, but this inverts it for the scroll wheel.

@nicodh
Copy link
Member Author

nicodh commented Nov 11, 2025

This might fix it for the pinch gesture on Mac, but this inverts it for the scroll wheel.

Yes I know, but that's what I experienced in my tests. Did you test it with your touchpad? On mine the behaviour was wrong on Linux too. But maybe since I had to use an external touchpad which behaved like a Mac??

@WofWca
Copy link
Member

WofWca commented Nov 11, 2025

No, I only tested with a mouse.

@nicodh nicodh changed the title fix: invert pinch zoom on mac fix: invert pinch zoom direction Nov 11, 2025
@nicodh nicodh requested a review from WofWca November 11, 2025 13:27
@WofWca
Copy link
Member

WofWca commented Nov 11, 2025

@nicodh You seem to have edited my comment?

Have you tried using the mouse scroll wheel? It's supposed to be "scroll up to zoom in, scroll down to zoom out", which it is not in this MR.

@nicodh
Copy link
Member Author

nicodh commented Nov 11, 2025

@nicodh You seem to have edited my comment? Sorry not by purpose - I will restore it

Have you tried using the mouse scroll wheel? It's supposed to be "scroll up to zoom in, scroll down to zoom out", which it is not in this MR.

Hmm, for me I have the opposite behaviour. What do you see in main branch when opening the full screen view (like in media gallery). There I see: scroll down => zoom in, scoll up => zoom out
The same behaviour I have in apps like gThumbs etc.

But most important: the scroll behaviour is th opposite of the behaviour in the Image Cropper. Can you confirm that? (in main branch)

@nicodh
Copy link
Member Author

nicodh commented Nov 11, 2025

No, I only tested with a mouse.

So for me even Ctr + mouse move has the same zoom direction as other applications (and other components in desktop) with this PR.

Before it was just the opposition direction in the ImageCropper.

But of course the PR title is wrong then and I will change it

@WofWca
Copy link
Member

WofWca commented Nov 11, 2025

For me it's "scroll up to zoom in" in the fullscreen image view. Same is on the main branch for the image cropper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behaviour for pinch gesture on Mac

3 participants