Skip to content

Conversation

@canaleal
Copy link
Member

@canaleal canaleal commented Nov 4, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1664

Link to prove your SVG is correct and up-to-date.

The libgdx original logo contains the full name of the tool. As such, aliases were used for all the wordmark versions with only the original, plain, and line SVGs created.

I went with #e74a45 as the fill color for the plain and line SVGs as it's the main color for the tool.

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 4, 2023
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weh weh requested review from a team, ConX, Snailedlt and lunatic-fox and removed request for a team November 13, 2023 17:00
@canaleal
Copy link
Member Author

No artifacts in the font SVG's.

image

image

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 4fe4251 into devicons:develop Nov 11, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: libgdx (original, plain, line)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants