Exclude assembly that is added by consumed package targets

[quasarea]

Hi,

I have library that depends on Grpc.Core package. This package has a targets file that adds assemblies to output

...
  <ItemGroup Condition="'$(Grpc_SkipNativeLibsCopy)' != 'true'">
    <Content Include="$(MSBuildThisFileDirectory)..\..\runtimes\win-x86\native\grpc_csharp_ext.x86.dll">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
      <Link>grpc_csharp_ext.x86.dll</Link>
      <Visible>false</Visible>
    </Content>
...

How can I exclude grpc_csharp_ext.x86.dll from being packaged? I have tried several combinations of

    <PackInference Update="Content" PackExclude="**/grpc_csharp_ext.x86.dll;**/grpc_csharp_ext.x64.dll" />
    <PackInference Update="Content" PackExclude="$(OutputPath)/**/grpc_csharp_ext.x64.dll" />
    <PackInference Update="Content" PackExclude="$(OutputPath)/grpc_csharp_ext.x64.dll" />
    <PackInference Update="Content" PackExclude="**/grpc_csharp_ext.x64.dll" />

But nothing worked :(

[kzu]

Ok, given this project:

<Project Sdk="Microsoft.NET.Sdk">

	<PropertyGroup>
		<TargetFramework>netstandard2.1</TargetFramework>
		<PackageId>GrpcLib</PackageId>
	</PropertyGroup>

	<ItemGroup>
		<PackageReference Include="Grpc.Core" Version="2.38.1" />
		<PackageReference Include="NuGetizer" Version="0.7.2" />
	</ItemGroup>

</Project>

This is what nugetize shows:

which matches what's packed, so I'd say it's working as expected. could you perhaps provide a repro?

[quasarea]

Sorry, should mention that, needs to be .net framework 4.5+ to repro, as targets in package are:

[quasarea]

Project attached, but its just blank 4.8 with dependencies as above.
NugetizerIgnore.zip

PS C:\source\NugetizerIgnore> nugetize
Project C:\source\NugetizerIgnore\NugetizerIgnore.sln is not packable, rendering its contributed package contents.
  Dependencies:
    net472
      Grpc.Core, 2.36.4
  Contents:
    /lib/
      net472/
        grpc_csharp_ext.x64.dll
        grpc_csharp_ext.x86.dll
        libgrpc_csharp_ext.x64.dylib
        libgrpc_csharp_ext.x64.so
        NugetizerIgnore.exe
        NugetizerIgnore.exe.config
        NugetizerIgnore.pdb

[kzu]

Ok, to make the "fix" reliable (note: this is not a nugetizer issue, since arbitrary targets can add arbitrary files), I submitted this PR to Grps.Core: grpc/grpc#26725.

The solution you are looking for (given the currently shipping Grpc.Core) would be:

	<Target Name="ExcludeGrpcContentFromPack" BeforeTargets="InferPackageContents">
		<ItemGroup>
			<Content Update="@(Content -> WithMetadataValue('DefiningProjectName', 'Grpc.Core'))" Pack="false" />
		</ItemGroup>
	</Target>

When/if they accept my PR, you'd change DefiningProjectName with NuGetPackageId and that's it.

Here's the output from nugetize with that target in place:

[kzu]

I'm currently investigating why the update to PackInference you made didn't kick in, also.

[kzu]

The related bug for this has shipped and allows you to exclude all these library items with:

<PackInference Update="Content" PackExclude="**/*grpc_csharp_ext*.*" />

[quasarea]

Would you expect it to work on everything, like if I would like to not package pdb from the build, would the below work?

<ItemGroup>
   <PackInference Update="Content" PackExclude="**/*.pdb" />
</ItemGroup>

Asking as it doesn't in 4.8, unless I'm doing something totally wrong here.

I want to generate pdb, for in example binskim, but in some cases I don't want to expose it.

[kzu]

Pdbs are part of the primary build output, not content. For that scenario you would just set PackSymbols=false instead as documented in the readme

[quasarea]

Hi, sorry, I'm still struggling with exclusion (grpc included your change in current prerelease package.

I added custom target to update it like you demonstrated:

<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build" ToolsVersion="15.0">
  <Target Name="ExcludeGrpcContentFromPack" BeforeTargets="InferPackageContents">
    <Message Importance="high" Text="--- ExcludeGrpcContentFromPack ---" />
    <Message Importance="high" Text="@(Content -> WithMetadataValue('NuGetPackageId', 'Grpc.Core'))" />
    <ItemGroup>
      <Content Update="@(Content -> WithMetadataValue('NuGetPackageId', 'Grpc.Core'))" Pack="false" />
    </ItemGroup>
  </Target>
</Project>

Target is executed during both nugetize and msbuild

PS C:\git\ExclusionTest> nugetize
  Determining projects to restore...
  Restored C:\git\ExclusionTest\ExclusionTest\ExclusionTest.csproj (in 152 ms).
  --- ExcludeGrpcContentFromPack ---
  C:\Users\user\.nuget\packages\grpc.core\2.41.0-pre2\build\net45\..\..\runtimes\win-x86\native\grpc_csharp_ext.x86.dll;
  C:\Users\user\.nuget\packages\grpc.core\2.41.0-pre2\build\net45\..\..\runtimes\win-x64\native\grpc_csharp_ext.x64.dll;
  C:\Users\user\.nuget\packages\grpc.core\2.41.0-pre2\build\net45\..\..\runtimes\linux-x64\native\libgrpc_csharp_ext.x64.so;
  C:\Users\user\.nuget\packages\grpc.core\2.41.0-pre2\build\net45\..\..\runtimes\osx-x64\native\libgrpc_csharp_ext.x64.dylib
Package: ExclusionTest.0.0.1.nupkg
         C:\git\ExclusionTest\ExclusionTest\bin\ExclusionTest.nuspec
    Authors    : Authors
    Description: Package Description
    Version    : 0.0.1
  Dependencies:
    net48
      Grpc.Core, 2.41.0-pre2
  Contents:
    /lib/
      net48/
        ExclusionTest.dll
        ExclusionTest.pdb
        grpc_csharp_ext.x64.dll
        grpc_csharp_ext.x86.dll
        libgrpc_csharp_ext.x64.dylib
        libgrpc_csharp_ext.x64.so

Here is my sample project with targets and rsp so just do msbuild

ExclusionTest.zip

[quasarea]

@kzu could it be because we are excluding assemblies from nuget global folder, while nugetizer (in generated nuspec) adds same assemblies but from local build folder

...
    <file src="C:\git\ExclusionTest\Build\grpc_csharp_ext.x86.dll" target="lib\net48\grpc_csharp_ext.x86.dll" />
    <file src="C:\git\ExclusionTest\Build\grpc_csharp_ext.x64.dll" target="lib\net48\grpc_csharp_ext.x64.dll" />
    <file src="C:\git\ExclusionTest\Build\libgrpc_csharp_ext.x64.so" target="lib\net48\libgrpc_csharp_ext.x64.so" />
    <file src="C:\git\ExclusionTest\Build\libgrpc_csharp_ext.x64.dylib" target="lib\net48\libgrpc_csharp_ext.x64.dylib" />

[quasarea]

Ok, the

  <ItemGroup>
    <PackInference Update="Content" PackExclude="**/*grpc_csharp_ext.*" />
  </ItemGroup>

works fine now, so I will use this instead of target based exclusion

[kzu]

I sent this PR upstream too and got merged, so that can also provide an alternative: grpc/grpc#26725 (using the PackageId metadata for those files)